[CORRUPTED] Synthetic Benchmark PR #41217 - fix: updates the logic to not interfere with DSL when infinitescroll is enabled #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07/10 - Daily promotion
08/10 Daily Promotion
10/10 Daily Promotion
11/10 - Daily Promotion
14/10 Daily Promotion
17/10 Daily Promotion
18/10 Daily Promotion
21/10 Daily Promotion
23/10 Daily Promotion
24/10 Daily Promotion
25/10 Daily Promotion
28/10 Daily Promotion
30/10 Daily Promotion
05/11 Daily Promotion
06/11 Daily Promotion
11/11 Daily Promotion
12/11 Daily Promotion
15/11/24 Daily Promotion
18/11 Daily Promotion
19/11 - Daily promotion
21/11 Daily Promotion
22/11 Daily Promotion
25/11 - Daily promotion
Fixes issue where the detection for signup when using OAuth was not being handled correctly. [Slack conversation](https://theappsmith.slack.com/archives/C02K2MZERSL/p1732600773587469?thread_ts=1732554015.110689&cid=C02K2MZERSL). ## Automation /test sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12024883331> > Commit: d53fcdf > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12024883331&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: @tag.Sanity > Spec: > It seems like **no tests ran** 😔. We are not able to recognize it, please check <a href="https://github.com/appsmithorg/appsmith/actions/runs/12024883331" target="_blank">workflow here</a>. > <hr>Tue, 26 Nov 2024 06:16:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved handling of user authentication success, enhancing the flow for email verification and OAuth2 authentication. - **Refactor** - Simplified the logic for determining user sign-up or login status. - Streamlined the method for handling OAuth2 redirects, improving clarity and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…ppsmithorg#37785) (cherry picked from commit 4727b4d)
25/06 Daily Promotion
26/06 Daily Promotion
27/06 Daily Promotion
30/06 Daily Promotion
03/07 Daily Promotion
04/07 Daily Promotion
07/07 Daily Promotion
09/07 - Daily promotion
11/07 Daily Promotion
14/07 Daily Promotion
16/07 Daily Promotion
23/07 Daily Promotion
28/07 Daily Promotion
…mithorg#41147) ## Description Updating the logo in the app editor to use favicon instead Fixes [appsmithorg#41134](appsmithorg#41134) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/16591754385> > Commit: 29ca678 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Tue, 29 Jul 2025 09:11:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Updated the logo in the Appsmith link to display the organization's favicon if available and different from the default, otherwise defaults to the standard logo. * **Bug Fixes** * Increased the maximum allowed favicon size in branding settings from 32x32 to 48x48 pixels, with updated validation and messaging. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…go-cherry-pick fix: Updating the logo in the app editor to use favicon instead (appsmithorg#41147)
30/07 Daily Promotion
31/07 Daily Promotion
01/08 Daily Promotion
04/08 Daily Promotion
11/08 Daily Promotion
13/08 Daily Promotion
Daily Promotion - 21/08
Refines the editability condition for header cells in the TableWidgetV2 to ensure that cells are only editable when infinite scrolling is disabled. - Added a condition to check if infinite scrolling is not enabled before allowing cell editability in `HeaderCell.tsx`. - Removed the unused update function related to cell editability from the content configuration. This change improves the user experience by preventing unintended edits in scenarios where infinite scrolling is active, ensuring a more predictable behavior of the table component.
This is important for width calculations because when infinite scroll is turned down we are not going to show edit capabilities.
…WidgetV2 This update adds the `infiniteScrollEnabled` prop to various cell components (BasicCell, DateCell, PlainTextCell, SelectCell) within the TableWidgetV2. The editability logic for cells is adjusted to ensure that cells are only editable when infinite scrolling is disabled, enhancing user experience and maintaining consistent behavior across the table component. - Added `infiniteScrollEnabled` prop to BasicCell, DateCell, PlainTextCell, and SelectCell. - Updated cell editability conditions to respect the infinite scroll setting. This change builds upon previous work to improve the TableWidgetV2's functionality and user interaction.
…infinite scroll This update refines the editability conditions for the TableWidgetV2, ensuring that the `isColumnTypeEditable` function now accepts an `isInfiniteScrollEnabled` parameter. This change allows for more accurate control over cell editability based on the infinite scroll setting. - Updated `isColumnTypeEditable` function to include `isInfiniteScrollEnabled` parameter. - Adjusted editability checks in `HeaderCell.tsx` and `index.tsx` to utilize the new parameter. - Ensured consistent behavior across the table component regarding cell editability when infinite scrolling is enabled. This refactor builds upon previous enhancements to improve user experience and maintain predictable behavior in the TableWidgetV2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR appsmithorg#41217
Type: Corrupted (contains bugs)
Original PR Title: fix: updates the logic to not interfere with DSL when infinitescroll is enabled
Original PR Description:
Description
TLDR:
Refines TableWidgetV2 cell editability logic to disable editing when infinite scroll is enabled.
Problem
When people toggled infinite scroll of ON and then moved it back to ON, we were forcibly enabling editing for all columns which was wrong product behavior.
Root cause
The utilities were putting the additables to true in DSL.
And editability logic missed a check for the infinite scroll setting, causing cells to remain editable even when infinite scroll was active.
Solution
This PR handles the integration of infinite scroll support into TableWidgetV2 by updating header and cell components to respect the infiniteScrollEnabled prop. Editability is now disabled when infinite scroll is active, ensuring consistent and predictable user experience.
Fixes #
Issue Numberor
Fixes https://github.com/appsmithorg/appsmith-ee/issues/8144
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Table"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/17998257804
Commit: 4d0ff9c
Cypress dashboard.
Tags:
@tag.TableSpec:
Thu, 25 Sep 2025 06:15:12 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Original PR URL: appsmithorg#41217
Issues Breakdown