wireplumber: Enable bluez plugin. #100
Conversation
rbujala-quic
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
| SYSTEMD_SERVICE:${PN} = "wireplumber.service" | ||
| SYSTEMD_AUTO_ENABLE:${PN} = "enable" | ||
|
|
||
| SRC_URI:append:qcom = " file://0001-Enable-bluez-plugin.patch \ |
There was a problem hiding this comment.
Please keep the same flow of the recipe in the bbappend: SRC_URI right below FILESEXTRAPATHS, do_install:append above SYSTEMD_*.
There was a problem hiding this comment.
update as per the suggestions and removed existing flag from the change.
| hardware.audio = required | ||
| hardware.bluetooth = required | ||
| hardware.video-capture = required | ||
| + monitor.bluez.seat-monitoring = disabled |
There was a problem hiding this comment.
Isn't this enabled by default in systemwide-session profile [1] which is now enabled by default when using wireplumber service [2] ?
[1] https://github.com/PipeWire/wireplumber/blob/ceed5dca7c19c287dd75c32e73cd4e99d9d88445/src/config/wireplumber.conf#L144
[2] https://github.com/PipeWire/wireplumber/blob/ceed5dca7c19c287dd75c32e73cd4e99d9d88445/src/systemd/system/wireplumber.service.in#L15
There was a problem hiding this comment.
seems this flag is already available as part of mixin from wireplumber 0.5.6 and it did not require further.
thanks
Add bluetooth configuration file in wireplumber delta conf folder for user preferred bluez configuration. Signed-off-by: Raghavender Reddy Bujala <[email protected]>
rbujala-quic
force-pushed
the
enable_bluez
branch
from
14604ce to
bfd3327
Compare
| do_install:append:qcom () { | ||
| install -v -m 0644 \ | ||
| ${S}/src/config/wireplumber.conf.d.examples/bluetooth.conf \ | ||
| ${D}${datadir}/wireplumber/wireplumber.conf.d/ |
There was a problem hiding this comment.
It seems this is already getting installed in /usr/share/doc/wireplumber/examples and the contents are commented out. So, what does this achieve?
There was a problem hiding this comment.
This bluetooth.conf file is not seen on target and this we have added for user to choose bluetooth configurations for connection and to set sampling rate etc.,
user has to uncomment and use the preferred settings.
one example: this is required for switch between native and ofono for hfp client usecase
bluez5.hfphsp-backend = "native"
There was a problem hiding this comment.
This goes in wireplumber-doc which I think is correct since this is essentially an example and not doing anything.
There was a problem hiding this comment.
this is required, without this we can't test ofono usecase and hfp client will be considered as depored.
and this needs to be in /usr/share/wireplumber/wireplumber.conf.d/ folder to pick the configuration
There was a problem hiding this comment.
It doesn't look like there is anything defined in that file, most of the lines are commented out. Please either fix it via the patch or provide an actual config file in the repo and then install it to the target. In the latter case, I'd recomment installing it via a separate package instead of hijacking the wireplumber recipe.
There was a problem hiding this comment.
If you want to enable a runtime-based configuration, then have the fragment you want in a separated package, which the user can then install based on the desired default behavior.
5 participants
The BlueZ monitors are integrated with logind to
ensure that only one user at a time can use the
Bluetooth audio devices.on QLI devices, there is
no user login sessions enabled. so disable this
feature will allow bluez plugin to launch without
looking for logind session.
Add bluetooth configuration file in wireplumber
delta conf folder for user preferred configuration.