-
Notifications
You must be signed in to change notification settings - Fork 23
wireplumber: Enable bluez plugin. #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rbujala-quic
wants to merge
1
commit into
qualcomm-linux:main
Choose a base branch
from
rbujala-quic:enable_bluez
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| do_install:append:qcom () { | ||
| install -v -m 0644 \ | ||
| ${S}/src/config/wireplumber.conf.d.examples/bluetooth.conf \ | ||
| ${D}${datadir}/wireplumber/wireplumber.conf.d/ | ||
| } | ||
|
|
||
| # Enable wireplumber as a system-wide service | ||
| SYSTEMD_SERVICE:${PN} = "wireplumber.service" | ||
| SYSTEMD_AUTO_ENABLE:${PN} = "enable" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this is already getting installed in
/usr/share/doc/wireplumber/examplesand the contents are commented out. So, what does this achieve?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bluetooth.conf file is not seen on target and this we have added for user to choose bluetooth configurations for connection and to set sampling rate etc.,
user has to uncomment and use the preferred settings.
one example: this is required for switch between native and ofono for hfp client usecase
bluez5.hfphsp-backend = "native"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes in
wireplumber-docwhich I think is correct since this is essentially an example and not doing anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is required, without this we can't test ofono usecase and hfp client will be considered as depored.
and this needs to be in /usr/share/wireplumber/wireplumber.conf.d/ folder to pick the configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like there is anything defined in that file, most of the lines are commented out. Please either fix it via the patch or provide an actual config file in the repo and then install it to the target. In the latter case, I'd recomment installing it via a separate package instead of hijacking the wireplumber recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to enable a runtime-based configuration, then have the fragment you want in a separated package, which the user can then install based on the desired default behavior.