qcom-base.inc: enable tarballs as additional image format #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumag
reviewed
Mar 18, 2025
lumag
reviewed
Mar 18, 2025
| # Avoid to duplicate the rootfs tarball by generating both tar.gz/tar.xz | ||
| IMAGE_FSTYPES:remove = "tar.gz" | ||
| IMAGE_FSTYPES:remove = "tar.xz" | ||
| IMAGE_FSTYPES:append = " tar.gz" |
There was a problem hiding this comment.
If it is a current default, do we need to append it manually?
There was a problem hiding this comment.
See previous comment
There was a problem hiding this comment.
Append is kind of evil as it will affect every image related recipe, including initramfs images (since they just replace the value with a normal set '=').
There was a problem hiding this comment.
Actually... What is the primary reason for enabling/changing tarball generation at all? It looks like a user decision instead of a setting that we should be enforcing in the distro configuration.
Enable `tar.gz` to be able to populate external media like microSD cards a bit easier. OE-core has `tar.gz` as its default, but BSP layers tend to overwrite that, so DISTROs need to use `:append` to ensure the desired types get generated. Gzip has been picked over xz because of its speed, both in compression as in decompression. With `pigz` installed it scales linearly with the number of CPU cores, removing it as the bottleneck. Signed-off-by: Koen Kooi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream OE changed the defaults, so the original stanza prevented all types of tarballs. Enable
tar.gzto be able to populate external media like microSD cards a bit easier.Gzip has been picked over xz because of its speed, both in compression as in decompression. With
pigzinstalled it scales linearly with the number of CPU cores, removing it as the bottleneck.