Skip to content

qcom-base.inc: enable tarballs as additional image format #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

qcom-base.inc: enable tarballs as additional image format #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions conf/distro/include/qcom-base.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ IMAGE_FSTYPES += "qcomflash"
# Set a default package class to avoid surprises
PACKAGE_CLASSES = "package_ipk"

# Avoid to duplicate the rootfs tarball by generating both tar.gz/tar.xz
IMAGE_FSTYPES:remove = "tar.gz"
# Force tarballs being generated, some BSP layers overwrite
# IMAGE_FSTYPES, so this appends 'tar.gz' regardless of what the BSP
# tried to remove
IMAGE_FSTYPES:append = " tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is a current default, do we need to append it manually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append is kind of evil as it will affect every image related recipe, including initramfs images (since they just replace the value with a normal set '=').

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually... What is the primary reason for enabling/changing tarball generation at all? It looks like a user decision instead of a setting that we should be enforcing in the distro configuration.


# Pull in the initrd image by default
INITRAMFS_IMAGE_BUNDLE ?= "1"
Expand Down