qcom-multimedia-proprietary-image: replace individual pkgs with a group #65
Conversation
vkraleti
requested review from
lumag,
ndechesne,
ricardosalveti and
sbanerjee-quic
as code owners
recipes-products/packagegroups/packagegroup-qcom-proprietary-pkgs.bb
Outdated
Show resolved
Hide resolved
recipes-products/packagegroups/packagegroup-qcom-proprietary-pkgs.bb
Outdated
Show resolved
Hide resolved
vkraleti
force-pushed
the
mm-prop-img
branch
from
390c020 to
0d09c51
Compare
| CORE_IMAGE_BASE_INSTALL += " \ | ||
| iris-video-dlkm \ | ||
| kgsl-dlkm \ | ||
| CORE_IMAGE_BASE_INSTALL:append:aarch64 = " \ |
There was a problem hiding this comment.
I think the whole image doesn't make sense for 32-bit ARM. So it might be better to make it compatible with AArch64 only.
There was a problem hiding this comment.
Scaling meta-qcom CI is much easier if all images from meta-qcom-distro can be built across all supported machines. Otherwise, we introduce an additional variable into an already complex build matrix.
In that sense, I believe it's more viable to keep the image generic and manage package installation through machine-specific overrides.
There was a problem hiding this comment.
I was hoping we could make the image recipe compatible with aarch64, and that it would just be ignored/skipped nicely, but it does not and it fails with "XXX was skipped: incompatible with machine qcom-armv7a (not in COMPATIBLE_MACHINE)"
with the world build coming up, we will need a proper solution. we need that recipe to build or to be skipped (in which case we update our CI targets).
Introduce a packagegroup containing downstream extensions specific to QCOM supported images that primarily showcases proprietary features that are not fully supported in upstream builds. Signed-off-by: Viswanath Kraleti <[email protected]>
Replace individual packages listing with pg-qcom-proprietary-pkgs in qcom-multimedia-proprietary-image recipe. Consolidating proprietary packages under a unified packagegroup, simplify image composition and improve maintainability. Signed-off-by: Viswanath Kraleti <[email protected]>
vkraleti
force-pushed
the
mm-prop-img
branch
from
0d09c51 to
b0c0473
Compare
|
I gave this another thought. I think this might be a bit premature. I think it might be better to keep on listing individual packages until we see more proprietary features enabled. |
Ok, I'll pause this PR for now. Fixed the COMPATIBLE_MACHINE of qcom-multimedia-proprietary-image via #69 |
4 participants
Consolidating proprietary packages under a unified package group, simplify image composition and improve maintainability.