Skip to content

qcom-multimedia-proprietary-image: replace individual pkgs with a group #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −3
Draft

qcom-multimedia-proprietary-image: replace individual pkgs with a group #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b93be
packagegroups: define qcom proprietary packagegroup
vkraleti Sep 12, 2025
b0c0473
qcom-multimedia-proprietary-image: replace individual pkgs with a group
vkraleti Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions recipes-products/images/qcom-multimedia-proprietary-image.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ require qcom-multimedia-image.bb

SUMMARY = "An image built on top of multimedia image for proprietary features"

CORE_IMAGE_BASE_INSTALL += " \
iris-video-dlkm \
kgsl-dlkm \
CORE_IMAGE_BASE_INSTALL:append:aarch64 = " \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whole image doesn't make sense for 32-bit ARM. So it might be better to make it compatible with AArch64 only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scaling meta-qcom CI is much easier if all images from meta-qcom-distro can be built across all supported machines. Otherwise, we introduce an additional variable into an already complex build matrix.
In that sense, I believe it's more viable to keep the image generic and manage package installation through machine-specific overrides.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we could make the image recipe compatible with aarch64, and that it would just be ignored/skipped nicely, but it does not and it fails with "XXX was skipped: incompatible with machine qcom-armv7a (not in COMPATIBLE_MACHINE)"

with the world build coming up, we will need a proper solution. we need that recipe to build or to be skipped (in which case we update our CI targets).

packagegroup-qcom-proprietary-pkgs \
"

14 changes: 14 additions & 0 deletions recipes-products/packagegroups/packagegroup-qcom-proprietary-pkgs.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
SUMMARY = "Extended proprietary packages for QCOM platforms"

# Incompatible with all archs except aarch64 (ARMv8)
COMPATIBLE_MACHINE = "^$"
COMPATIBLE_MACHINE:aarch64 = "(.*)"

PACKAGE_ARCH = "${MACHINE_ARCH}"

inherit packagegroup

RDEPENDS:${PN} = " \
iris-video-dlkm \
kgsl-dlkm \
"
Loading