qcom-multimedia-proprietary-image: add qcom-fastcv-binaries #93
Conversation
Include qcom-fastcv-binaries in qcom-multimedia-proprietary-image Signed-off-by: Pulkit Singh Tak <[email protected]>
quic-ptak
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
| iris-video-dlkm \ | ||
| kgsl-dlkm \ | ||
| qcom-adreno \ | ||
| qcom-fastcv-binaries \ |
There was a problem hiding this comment.
Why are we explicitly installing it? Wouldn't it come as a dependency of OpenCV?
There was a problem hiding this comment.
OpenCV uses static linkage of fastcv libs. It doesn't depend on qcom-fastcv-binaries recipe. The packageconfig "fastcv" merely enabled FastCV HAL based fucntions and extensions in OpenCV layer.
There was a problem hiding this comment.
Then why do we need to install it into the rootfs? Please pick up only the parts which are required at runtime
There was a problem hiding this comment.
Our real requirement is to make qcom-fastcv-binaries package part of qcom-multimedia-proprietary-image. The recipe: qcom-fastcv-binaries provides main package with same name and machine related cdsp packages. We want the main package as well as the machine dependent packages to be part of this image.
There was a problem hiding this comment.
Why? Please split the libfastcvdsp_stub.so.1.8.0 to a separate package. Then the main package will contain only the library, which will be pulled automatically by the packages which depend on it.
There was a problem hiding this comment.
Applications using FastCV functions require libfastcvopt.so, which serves as the primary entry point for FastCV operations.
libfastcvopt.so depends on libfastcvdsp_stub.so.1.8.0, which facilitates offloading computations to the DSP.
For DSP execution, machine-specific FastCV DSP skel libraries must be present. These libraries are packaged separately for each supported board.
Any FastCV-based application running on DSP requires:
- libfastcvopt.so (host-side)
- libfastcvdsp_stub.so.1.8.0 (host-side DSP stub)
- Board-specific DSP skel libraries (DSP-side)
FastCV DSP based OpenCV Extensions -> (Runtime dynamic linking (#1)) -> libfastcvopt.so -> libfastcvdsp_stub.so (HLOS) -> (Runtime(#2), offload to CDSP via RPC) -> libfastcvdsp_skel.so (CDSP)
for #1, we need to mention RDEPENDS to qcom-fastcv-binaries in Opencv bbappend
for #2, we need to mention RDEPENDS to on board-wise DSP packages in qcom-fastcv-binaries
FastCV clients like Camera:
Camera using Fastcv offload to DSP ->(Compiletime static linking) -> libfastcvopt.so -> libfastcvdsp_stub.so (HLOS) -> (Runtime) , offload to CDSP via RPC) -> libfastcvdsp_skel.so (CDSP)
Can we add machine based if checks to make qcom-fastcv-binaries RDEPENDS on DSP packages in bb ?
2 participants
Include qcom-fastcv-binaries in qcom-multimedia-proprietary-image