Skip to content

qcom-multimedia-proprietary-image: add qcom-fastcv-binaries #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

qcom-multimedia-proprietary-image: add qcom-fastcv-binaries #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions recipes-products/images/qcom-multimedia-proprietary-image.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ CORE_IMAGE_BASE_INSTALL += " \
iris-video-dlkm \
kgsl-dlkm \
qcom-adreno \
qcom-fastcv-binaries \
Copy link
Contributor

@lumag lumag Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we explicitly installing it? Wouldn't it come as a dependency of OpenCV?

Copy link
Author

@quic-ptak quic-ptak Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCV uses static linkage of fastcv libs. It doesn't depend on qcom-fastcv-binaries recipe. The packageconfig "fastcv" merely enabled FastCV HAL based fucntions and extensions in OpenCV layer.

Copy link
Contributor

@lumag lumag Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why do we need to install it into the rootfs? Please pick up only the parts which are required at runtime

Copy link
Author

@quic-ptak quic-ptak Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our real requirement is to make qcom-fastcv-binaries package part of qcom-multimedia-proprietary-image. The recipe: qcom-fastcv-binaries provides main package with same name and machine related cdsp packages. We want the main package as well as the machine dependent packages to be part of this image.

Copy link
Contributor

@lumag lumag Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Please split the libfastcvdsp_stub.so.1.8.0 to a separate package. Then the main package will contain only the library, which will be pulled automatically by the packages which depend on it.

Copy link
Author

@quic-ptak quic-ptak Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applications using FastCV functions require libfastcvopt.so, which serves as the primary entry point for FastCV operations.
libfastcvopt.so depends on libfastcvdsp_stub.so.1.8.0, which facilitates offloading computations to the DSP.

For DSP execution, machine-specific FastCV DSP skel libraries must be present. These libraries are packaged separately for each supported board.

Any FastCV-based application running on DSP requires:

  • libfastcvopt.so (host-side)
  • libfastcvdsp_stub.so.1.8.0 (host-side DSP stub)
  • Board-specific DSP skel libraries (DSP-side)

FastCV DSP based OpenCV Extensions -> (Runtime dynamic linking (#1)) -> libfastcvopt.so -> libfastcvdsp_stub.so (HLOS) -> (Runtime(#2), offload to CDSP via RPC) -> libfastcvdsp_skel.so (CDSP)

for #1, we need to mention RDEPENDS to qcom-fastcv-binaries in Opencv bbappend
for #2, we need to mention RDEPENDS to on board-wise DSP packages in qcom-fastcv-binaries

FastCV clients like Camera:

Camera using Fastcv offload to DSP ->(Compiletime static linking) -> libfastcvopt.so -> libfastcvdsp_stub.so (HLOS) -> (Runtime) , offload to CDSP via RPC) -> libfastcvdsp_skel.so (CDSP)

Can we add machine based if checks to make qcom-fastcv-binaries RDEPENDS on DSP packages in bb ?

"
CORE_IMAGE_BASE_INSTALL:append = " \
${@bb.utils.contains('BBFILE_COLLECTIONS', 'meta-audioreach', ' packagegroup-audioreach', '', d)} \
Expand Down
Loading