Skip to content

ci: update code owners for qirp sdk#17

Merged
DapengYuan-David merged 1 commit intoqualcomm-linux:mainfrom
DotaIsMind:changeowner
Nov 6, 2025
Merged

ci: update code owners for qirp sdk#17
DapengYuan-David merged 1 commit intoqualcomm-linux:mainfrom
DotaIsMind:changeowner

Conversation

@DotaIsMind
Copy link
Contributor

  • Update code owners for robotics SDK layer reviewers

Copy link

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your name in the git config, then fix this commit to have it in the metadata and SoB tag. Also please write commit message.

@DotaIsMind
Copy link
Contributor Author

Please fix your name in the git config, then fix this commit to have it in the metadata and SoB tag. Also please write commit message.

Thanks for your review. My local git config shows that I'm using the correct name, and I've added the SoB tag using "git commit -s". Could you please review this PR again?

@lumag
Copy link

lumag commented Nov 3, 2025

Please fix your name in the git config, then fix this commit to have it in the metadata and SoB tag. Also please write commit message.

Thanks for your review. My local git config shows that I'm using the correct name, and I've added the SoB tag using "git commit -s". Could you please review this PR again?

Unless your name is just 'tengf' it is incorrect:

From: tengf <tengf@qti.qualcomm.com>
...
Signed-off-by: tengf <tengf@qti.qualcomm.com>

@DotaIsMind
Copy link
Contributor Author

Please fix your name in the git config, then fix this commit to have it in the metadata and SoB tag. Also please write commit message.

Thanks for your review. My local git config shows that I'm using the correct name, and I've added the SoB tag using "git commit -s". Could you please review this PR again?

Unless your name is just 'tengf' it is incorrect:

From: tengf <tengf@qti.qualcomm.com>
...
Signed-off-by: tengf <tengf@qti.qualcomm.com>

It has been changed to my full name. Thank you~

@lumag
Copy link

lumag commented Nov 4, 2025

Unknown owner on line 6: make sure @quic-weijshen exists and has write access to the repository
…gYuan-David @huiyqiu @fulaliu @quic-weijshen

change from meta-qcom to IoE Platform owners, as the previous configuration
reused the meta-qcom workflow, resulting in unnecessary email notifications.

Signed-off-by: Teng Fan <tengf@qti.qualcomm.com>
@DotaIsMind
Copy link
Contributor Author

Unknown owner on line 6: make sure @quic-weijshen exists and has write access to the repository
…gYuan-David @huiyqiu @fulaliu @quic-weijshen

Removed @quic-weijshen from the ci/* reviewer lists, he is the owner of kas config, we will apply write access for him.

@DotaIsMind DotaIsMind requested a review from lumag November 5, 2025 01:44
@DapengYuan-David DapengYuan-David merged commit 43d3c9e into qualcomm-linux:main Nov 6, 2025
7 checks passed
@DotaIsMind DotaIsMind deleted the changeowner branch December 8, 2025 06:36
DotaIsMind pushed a commit to DotaIsMind/meta-qcom-robotics-sdk that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants