Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions recipes-connectivity/control_app_dut/qcom-ath11k-fwtest_1.0.bb
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
SUMMARY = "Prebuilt Qualcomm ath11k firmware test utilities"
DESCRIPTION = "Prebuilt ath11k firmware test and validation utility"
LICENSE = "CLOSED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of CLOSED? No redistribution? Don't even think of installing? Please provide some kind of licence to be applied to this package.


PBT_BUILD_DATE = "251113.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move PBT_BUILD_DATE next to sha256sum, they will be updated together.

ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/wlan-service.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto"
SOC_ARCH = "armv8-2a"

SRC_URI = "${ARTIFACTORY_URL}/qcom-ath11k-fwtest_1.0_${SOC_ARCH}.tar.gz"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SRC_URI = "${ARTIFACTORY_URL}/qcom-ath11k-fwtest_1.0_${SOC_ARCH}.tar.gz"
SRC_URI = "${ARTIFACTORY_URL}/qcom-ath11k-fwtest_${PV}_${SOC_ARCH}.tar.gz"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inline ${ARTIFACTORY_URL} here, as requested in other recipes.

SRC_URI[sha256sum] = "40ce6dbbda86e95406bc5a74ebe62c99eb63242305f74b7234998dfdffb2fbc5"

S = "${UNPACKDIR}"

RDEPENDS:${PN} += "libnl libnl-genl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPENDS = "libnl", this would let OE do its job


# This package is currently only used and tested on ARMv8 (aarch64) machines.
# Therefore, builds for other architectures are not necessary and are explicitly excluded.
COMPATIBLE_MACHINE = "^$"
COMPATIBLE_MACHINE:aarch64 = "(.*)"

do_install() {
# Create any additional directories that might be needed
install -d ${D}${sbindir}

# Install the prebuilt files maintaining the directory structure
install -m 0755 ${S}/usr/sbin/* ${D}${sbindir}/
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inheriting bin_package can replace this and skip do_configure and do_compile if we only have binaries to be copied.


INSANE_SKIP:${PN} = "already-stripped"
27 changes: 27 additions & 0 deletions recipes-connectivity/control_app_dut/qcom-ctrl-app-dut_1.0.bb
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
SUMMARY = "Prebuilt Qualcomm Control Application DUT utilities"
DESCRIPTION = "Qualcomm Technologies Control Application for Device Under Test"
LICENSE = "CLOSED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be more specific


PBT_BUILD_DATE = "251028"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this next to sha256sum

ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/wlan-service.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto"
SOC_ARCH = "armv8-2a"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline both SOC_ARCH aind ARTIFACTORY_URL


SRC_URI = "${ARTIFACTORY_URL}/qcom-ctrl-app-dut_1.0_${SOC_ARCH}.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ${PV} instead of 1.0

SRC_URI[sha256sum] = "c639b71a3df65ec87a93c96e3bc68eb736fc5d9e9fafcaa6487df97a0e9638f1"

S = "${UNPACKDIR}"

# This package is currently only used and tested on ARMv8 (aarch64) machines.
# Therefore, builds for other architectures are not necessary and are explicitly excluded.
COMPATIBLE_MACHINE = "^$"
COMPATIBLE_MACHINE:aarch64 = "(.*)"

do_install() {
# Create any additional directories that might be needed
install -d ${D}${sbindir}

# Install the prebuilt files maintaining the directory structure
install -m 0755 ${S}/usr/sbin/* ${D}${sbindir}/
}

INSANE_SKIP:${PN} = "already-stripped"
Loading