recipes-test: Add recipe for diag-router #1273
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| SUMMARY = "Prebuilt Qualcomm diagnostic router application" | ||
| DESCRIPTION = "Prebuilt routing application for diagnostic traffic" | ||
| LICENSE = "LICENSE.qcom-2" | ||
| LIC_FILES_CHKSUM = "file://${UNPACKDIR}/usr/share/doc/diag-router/NO.LOGIN.BINARY.LICENSE.QTI.pdf;md5=7a5da794b857d786888bbf2b7b7529c8" | ||
|
|
||
| SRC_URI = "https://softwarecenter.qualcomm.com/nexus/generic/software/chip/component/core-technologies.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto/diag-router_15.0+really${PV}_armv8a.tar.gz" | ||
|
|
||
| PBT_BUILD_DATE = "251127" | ||
| SRC_URI[sha256sum] = "18c7fbe1e3cd6ef470cee7fa17210419795060c5ac1e092e14af204580e2908a" | ||
|
|
||
| S = "${UNPACKDIR}" | ||
|
|
||
| DEPENDS += "glib-2.0 libdiag qrtr" | ||
|
|
||
| # This package is currently only used and tested on ARMv8 (aarch64) machines. | ||
| # Therefore, builds for other architectures are not necessary and are explicitly excluded. | ||
| COMPATIBLE_MACHINE = "^$" | ||
| COMPATIBLE_MACHINE:aarch64 = "(.*)" | ||
|
|
||
| do_install() { | ||
| install -d ${D}${bindir} | ||
|
|
||
| # Install binaries | ||
| install -m 0755 ${S}/usr/bin/diag-router ${D}${bindir}/diag-router-qti | ||
|
Member
There was a problem hiding this comment. Why are you installing as diag-router-qti?
Contributor
Author
There was a problem hiding this comment. To not have conflicts with diag_git.bb
Contributor
There was a problem hiding this comment. Why do we need this package if we have an open-source one? Please work on improving the OSS one
Contributor
Author
There was a problem hiding this comment. this proprietary diag has many additional features as compared to the linux-msm/diag, the upstreaming is ongoing and it will take its time, so to enable users like audio and sensors with the required features this is the recommended diag-router-qti |
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEPENDS are build-time prerequisites, but you are not compiling.
Only installing a prebuilt binary. Using runtime dependencies should be good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure let me check this, might be able to cut dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbanerjee-quic it is also to let OE find out library runtime dependencies. I prefer it to listing library packages in RDEPENDS.