gst-plugins-imsdk: Enablement of python examples and qdemo application#1687
gst-plugins-imsdk: Enablement of python examples and qdemo application#1687muthumul wants to merge 1 commit intoqualcomm-linux:masterfrom
Conversation
Added python-examples PACKAGECONFIG and enabled it by default since it is only dependent on oe-core.
Installed Qdemo binary and media assets via do_install:append and defined ${PN}-qdemo package with
runtime dependencies. This will allow the python sample apps to be packaged as gst-plugins-imsdk-apps
and qdemo artifacts to be packaged as gst-plugins-imsdk-qdemo.
Signed-off-by: Muthumula Sai Harshith Reddy <muthumul@qti.qualcomm.com>
muthumul
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
| PACKAGECONFIG[tflite] = "-DENABLE_GST_PLUGIN_MLTFLITE=1, -DENABLE_GST_PLUGIN_MLTFLITE=0, tensorflow-lite" | ||
| PACKAGECONFIG[videoproc] = "-DENABLE_GST_VIDEOPROC_PLUGINS=1, -DENABLE_GST_VIDEOPROC_PLUGINS=0, cairo" | ||
|
|
||
| INSTALL_MEDIA = "${sysconfdir}/media" |
There was a problem hiding this comment.
No. Media is not a configuration. Move it to ${datadir}/${BPN}
There was a problem hiding this comment.
Also no need to define this variable, just use ${datadir}/${BPN}.
There was a problem hiding this comment.
No. Media is not a configuration. Move it to
${datadir}/${BPN}
Qdemo app is expecting qdemo artifacts to be part of /etc/media directory. So we are using ${sysconfdir}/media.
There was a problem hiding this comment.
Also no need to define this variable, just use ${datadir}/${BPN}.
Sure @ricardosalveti
There was a problem hiding this comment.
Yes, NAK for media content under /etc/media.
| mkdir -p ${D}${INSTALL_MEDIA} | ||
| install -m 755 ${S}/gst-python-examples/files/Qdemo ${D}${bindir}/ | ||
| install -m 755 ${S}/gst-python-examples/files/Qdemo.png ${D}${INSTALL_MEDIA} | ||
| install -m 755 ${S}/gst-python-examples/files/Qdemo.gif ${D}${INSTALL_MEDIA} |
|
|
||
| RDEPENDS:${PN}-qdemo += "bash" | ||
|
|
||
| RDEPENDS:${PN} += "${PN}-qdemo" |
There was a problem hiding this comment.
Why? You will now have ${PN}-oss-meta RDEPENDing on ${PN}-demo and ${PN}-apps already. ${PN} is empty.
| virtual/libgbm \ | ||
| virtual/libgles2 \ | ||
| virtual/libgles3 \ | ||
| gobject-introspection \ |
There was a problem hiding this comment.
If there are any introspection files to be built, then should inherit the gobject-introspection class instead.
5 participants
Added python-examples PACKAGECONFIG and enabled it by default since it is only dependent on oe-core. Installed Qdemo binary and media assets via do_install:append and defined ${PN}-qdemo package with runtime dependencies. This will allow the python sample apps to be packaged as gst-plugins-imsdk-apps and qdemo artifacts to be packaged as gst-plugins-imsdk-qdemo.