Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion recipes-multimedia/imsdk/gst-plugins-imsdk_git.bb
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,53 @@ DEPENDS += "\
virtual/libgbm \
virtual/libgles2 \
virtual/libgles3 \
gobject-introspection \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are any introspection files to be built, then should inherit the gobject-introspection class instead.

"

# This package is currently only used and tested on ARMv8 (aarch64) machines.
# Therefore, builds for other architectures are not necessary and are explicitly excluded.
COMPATIBLE_MACHINE = "^$"
COMPATIBLE_MACHINE:aarch64 = "(.*)"

PACKAGECONFIG ??= "sw videoproc"
PACKAGECONFIG ??= "python-examples sw videoproc"

PACKAGECONFIG[messaging] = "-DENABLE_GST_MESSAGING_PLUGINS=1, -DENABLE_GST_MESSAGING_PLUGINS=0, librdkafka mosquitto"
PACKAGECONFIG[ml] = "-DENABLE_GST_ML_PLUGINS=1, -DENABLE_GST_ML_PLUGINS=0, cairo json-glib opencv qairt-sdk, qairt-sdk"
PACKAGECONFIG[python-examples] = "-DENABLE_GST_PYTHON_EXAMPLES=1, -DENABLE_GST_PYTHON_EXAMPLES=0"
PACKAGECONFIG[qmmfsrc] = "-DENABLE_GST_PLUGIN_QMMFSRC=1 -DVHDR_MODES_ENABLE=ON, -DENABLE_GST_PLUGIN_QMMFSRC=0 -DVHDR_MODES_ENABLE=OFF, camera-service"
PACKAGECONFIG[redissink] = "-DENABLE_GST_PLUGIN_REDISSINK=1, -DENABLE_GST_PLUGIN_REDISSINK=0, hiredis"
PACKAGECONFIG[sw] = "-DENABLE_GST_SOFTWARE_PLUGINS=1, -DENABLE_GST_SOFTWARE_PLUGINS=0, gstreamer1.0-rtsp-server smart-venc-ctrl-algo"
PACKAGECONFIG[tflite] = "-DENABLE_GST_PLUGIN_MLTFLITE=1, -DENABLE_GST_PLUGIN_MLTFLITE=0, tensorflow-lite"
PACKAGECONFIG[videoproc] = "-DENABLE_GST_VIDEOPROC_PLUGINS=1, -DENABLE_GST_VIDEOPROC_PLUGINS=0, cairo"

INSTALL_MEDIA = "${sysconfdir}/media"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Media is not a configuration. Move it to ${datadir}/${BPN}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no need to define this variable, just use ${datadir}/${BPN}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Media is not a configuration. Move it to ${datadir}/${BPN}

Qdemo app is expecting qdemo artifacts to be part of /etc/media directory. So we are using ${sysconfdir}/media.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no need to define this variable, just use ${datadir}/${BPN}.

Sure @ricardosalveti

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muthumul then fix the app.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, NAK for media content under /etc/media.


do_install:append() {
mkdir -p ${D}${bindir}
mkdir -p ${D}${INSTALL_MEDIA}
install -m 755 ${S}/gst-python-examples/files/Qdemo ${D}${bindir}/
install -m 755 ${S}/gst-python-examples/files/Qdemo.png ${D}${INSTALL_MEDIA}
install -m 755 ${S}/gst-python-examples/files/Qdemo.gif ${D}${INSTALL_MEDIA}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this CMake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @lumag

}

PACKAGES =+ "${PN}-qdemo"

FILES:${PN}-qdemo = " \
${bindir}/Qdemo \
${INSTALL_MEDIA}/Qdemo.png \
${INSTALL_MEDIA}/Qdemo.gif \
"
# The TFLite plugin loads the TensorFlow Lite library at runtime using dlopen(). To ensure runtime availability, added runtime dependency on 'tensorflow-lite'.
RDEPENDS:${PN}-qtimltflite += "tensorflow-lite"

RDEPENDS:${PN}-apps += "\
python3-core \
gstreamer1.0-python \
python3-pygobject \
gtk+3 \
python3-opencv \
"

RDEPENDS:${PN}-qdemo += "bash"

RDEPENDS:${PN} += "${PN}-qdemo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? You will now have ${PN}-oss-meta RDEPENDing on ${PN}-demo and ${PN}-apps already. ${PN} is empty.