esp-qcom-image: convert to OE-core uki.bbclass #722
Conversation
koenkooi
requested review from
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
See qualcomm-linux/meta-qcom-hwe#138 for review and comment history |
koenkooi
force-pushed
the
koen/UKI
branch
2 times, most recently
from
11851e3 to
4f01b2b
Compare
|
|
||
| UKI_CMDLINE="root=${QCOM_BOOTIMG_ROOTFS} rw rootwait" | ||
|
|
||
| # Remove leading 'qcom/' from KERNEL_DEVICEREE, we store the file in DEPLOY_DIR_IMAGE directly, not in the qcom/ subfolder |
There was a problem hiding this comment.
do we need to keep these 2 lines here?
There was a problem hiding this comment.
The bottom one can go for sure, the top on is still needed AFAICT.
|
@koenkooi I think this is more or less ready now. Could you please squash those commits? Let's merge it, unless there are any obstacles. |
|
@koenkooi ping, let's finish and merge this. |
I've squashed and rebased it |
I think it's now failing on the copyright checks. LGTM otherwise. |
I've added a copyright header, but I do require some feedback on that:
|
You could define the range, but if owned by Qualcomm just updating to the latest is fine.
Yes, MIT is fine, that is our main license here. |
This class uses the OE-core uki.bbclass infrastructure to assemble an ESP image with systemd-boot + UKI. Systemd-boot is installed through package management, the UKI is picked up from deploy. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
koenkooi
changed the title
|
Jobs failed to run https://github.com/qualcomm-linux/meta-qcom/actions/runs/14358395851 |
github-project-automation
bot
moved this from In Progress
to Done
in Mainline Qualcomm Linux
|
Should had removed my approval, this PR is not yet fully functional, as I pasted above it fails to boot now. |
5 participants
This new class uses the OE-core uki.bbclass infrastructure to assemble an
ESP image with systemd-boot + UKI. It uses method #2 for config-less booting.
Systemd-boot is installed through package management, the UKI is picked
up from deploy.
Signed-off-by: Koen Kooi koen.kooi@oss.qualcomm.com
Fixes #707