Improve LAVA job titles #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job template sets DEVICE_TYPE=qcs6490-rb3gen2-vision-kit and this is the only CDT / DT we generate flash assets for at the moment. Signed-off-by: Loïc Minier <[email protected]>
Makes jobs slightly nicer in the GitHub view. Also avoid long pipeline with multiple sed calls and use plain jq instead. Signed-off-by: Loïc Minier <[email protected]>
Sort variable names. Signed-off-by: Loïc Minier <[email protected]>
BUILD_FILE_NAME is used in other templates to construct the download URL, but isn't used in meta-qcom or qcom-deb-images at the moment. Keep it present for future use, but align the list of variables being sed-ed in the templates in both workflows. Signed-off-by: Loïc Minier <[email protected]>
More consistent with other scripts. Signed-off-by: Loïc Minier <[email protected]>
Drop the device_type as it's already discoverable in the LAVA metadata. Also rename boot test to smoke tests as this matches the kind of tests we're pulling from test-definitions. Signed-off-by: Loïc Minier <[email protected]>
Test jobs for commit 18102c3 |
mwasilew
approved these changes
Oct 15, 2025
| BUILD_FILE_NAME="unused" | ||
| sed \ | ||
| -e "s|{{BUILD_DOWNLOAD_URL}}|${BUILD_DOWNLOAD_URL}|g" \ | ||
| -e "s|{{BUILD_FILE_NAME}}|${BUILD_FILE_NAME}|g" \ |
Contributor
There was a problem hiding this comment.
I don't think this is required. The whole section will be replaced with a templating tool.
Contributor
Author
There was a problem hiding this comment.
This variable isn't used, but I'm trying to keep the same set in both workflows
(Of course I'm super happy to drop all of this once we have a LAVA templating system in place!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small series of refactoring tweaks; the main goal is to improve the GH and LAVA job titles and tidy things up along the way