Skip to content

Improve LAVA job titles #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 15, 2025
Merged

Improve LAVA job titles #181

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87a3663
refactor(ci): Rename rb3gen2 to -vision-kit
lool Oct 14, 2025
2f59985
refactor(ci): drop ci/lava/ from job names
lool Oct 14, 2025
86e23de
refactor(ci): Consolidate sed calls
lool Oct 14, 2025
6e8b5ee
refactor(ci): sed BUILD_FILE_NAME in lava-test
lool Oct 14, 2025
676981e
refactor(ci): Use shebang to call schemacheck
lool Oct 14, 2025
18102c3
feat!(ci): Add gh repo and attempt to LAVA jobs
lool Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/lava-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ jobs:
# left-side – e.g. qrb2210-rb1
DEVICE_TYPE="${TARGET%/*}"
BUILD_DOWNLOAD_URL="$BUILD_URL"
BUILD_FILE_NAME="unused"
sed \
-e "s|{{BUILD_DOWNLOAD_URL}}|${BUILD_DOWNLOAD_URL}|g" \
-e "s|{{BUILD_FILE_NAME}}|${BUILD_FILE_NAME}|g" \
Copy link
Contributor

@mwasilew mwasilew Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is required. The whole section will be replaced with a templating tool.

Copy link
Contributor Author

@lool lool Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable isn't used, but I'm trying to keep the same set in both workflows

(Of course I'm super happy to drop all of this once we have a LAVA templating system in place!)

-e "s|{{DEVICE_TYPE}}|${DEVICE_TYPE}|g" \
-e "s|{{GITHUB_RUN_ID}}|${GITHUB_RUN_ID}|g" \
-e "s|{{GITHUB_SHA}}|${GITHUB_SHA}|g" \
Expand Down