Update qcom-fitimage.its #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fdt-lemans-evk-camera-csi1-imx577.dtbo in the FIT ITS to enable the UEFI firmware runtime overlay support for the efivars "camx". Signed-off-by: Kaushal Kumar <[email protected]>
| }; | ||
| conf-22 { | ||
| compatible = "qcom,qcs9075v2-iot-camx"; | ||
| fdt = "fdt-lemans-evk.dtb", "fdt-lemans-evk-camera-csi1-imx577.dtbo"; |
Member
There was a problem hiding this comment.
It will be good idea to add two dtdo names here.
for example for current testing an config entry that is being used is
conf-2 {
compatible = "qcom,qcs6490-iot-camx";
fdt = "fdt-qcs6490-rb3gen2.dtb", "fdt-qcs6490-rb3gen2-vision-mezzanine.dtbo", "fdt-qcs6490-rb3gen2-vision-mezzanine-camx.dtbo";
}
Collaborator
Author
There was a problem hiding this comment.
Sure will be updated in next patch
Collaborator
Author
| }; | ||
| conf-22 { | ||
| compatible = "qcom,qcs9075v2-iot-camx"; | ||
| fdt = "fdt-lemans-evk.dtb", "fdt-lemans-evk-camera-csi1-imx577.dtbo"; |
There was a problem hiding this comment.
Should we add the downstream camx overlay dtbo here (we are suffixing -camx) ?
List of camx dtbos that mainline is carrying presently,
- lemans-evk-camx.dtbo
- monaco-evk-camx.dtbo
- qcs8300-ride-camx.dtbo
- sa8775p-ride-camx.dtbo
Collaborator
Author
There was a problem hiding this comment.
The -camx suffix is added in compatible to be compared with the efivars. If a match is found, then the dtbo gets runtime overlayed by UEFI on top of the chosen DTB.
As discussed earlier since this is upstream project, we are only adding dts/dtso which are present upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fdt-lemans-evk-camera-csi1-imx577.dtbo in the FIT ITS to enable the UEFI firmware runtime overlay support for the efivars "camx".