Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions qcom-fitimage.its
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
data = /incbin/("./arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb");
type = "flat_dt";
};
fdt-lemans-evk-camera-csi1-imx577.dtbo {
data = /incbin/("./arch/arm64/boot/dts/qcom/lemans-evk-camera-csi1-imx577.dtbo");
type = "flat_dt";
};
};

configurations {
Expand Down Expand Up @@ -144,5 +148,13 @@
compatible = "qcom,hamoav2.1-evk";
fdt = "fdt-hamoa-iot-evk.dtb";
};
conf-21 {
compatible = "qcom,qcs9075-iot-camx";
fdt = "fdt-lemans-evk.dtb", "fdt-lemans-evk-camera-csi1-imx577.dtbo";
};
conf-22 {
compatible = "qcom,qcs9075v2-iot-camx";
fdt = "fdt-lemans-evk.dtb", "fdt-lemans-evk-camera-csi1-imx577.dtbo";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good idea to add two dtdo names here.
for example for current testing an config entry that is being used is

conf-2 {
                compatible = "qcom,qcs6490-iot-camx";
                fdt = "fdt-qcs6490-rb3gen2.dtb", "fdt-qcs6490-rb3gen2-vision-mezzanine.dtbo", "fdt-qcs6490-rb3gen2-vision-mezzanine-camx.dtbo";
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will be updated in next patch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I have pushed the new PR for our qcom-next overlay requirements:
#24

Pls review and let me know if this existing PR (#22) can be abandoned.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the downstream camx overlay dtbo here (we are suffixing -camx) ?
List of camx dtbos that mainline is carrying presently,

  • lemans-evk-camx.dtbo
  • monaco-evk-camx.dtbo
  • qcs8300-ride-camx.dtbo
  • sa8775p-ride-camx.dtbo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -camx suffix is added in compatible to be compared with the efivars. If a match is found, then the dtbo gets runtime overlayed by UEFI on top of the chosen DTB.

As discussed earlier since this is upstream project, we are only adding dts/dtso which are present upstream.

};
};
};
Loading