-
Notifications
You must be signed in to change notification settings - Fork 3
Update qcom-fitimage.its #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,6 +61,10 @@ | |
| data = /incbin/("./arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb"); | ||
| type = "flat_dt"; | ||
| }; | ||
| fdt-lemans-evk-camera-csi1-imx577.dtbo { | ||
| data = /incbin/("./arch/arm64/boot/dts/qcom/lemans-evk-camera-csi1-imx577.dtbo"); | ||
| type = "flat_dt"; | ||
| }; | ||
| }; | ||
|
|
||
| configurations { | ||
|
|
@@ -144,5 +148,13 @@ | |
| compatible = "qcom,hamoav2.1-evk"; | ||
| fdt = "fdt-hamoa-iot-evk.dtb"; | ||
| }; | ||
| conf-21 { | ||
| compatible = "qcom,qcs9075-iot-camx"; | ||
| fdt = "fdt-lemans-evk.dtb", "fdt-lemans-evk-camera-csi1-imx577.dtbo"; | ||
| }; | ||
| conf-22 { | ||
| compatible = "qcom,qcs9075v2-iot-camx"; | ||
| fdt = "fdt-lemans-evk.dtb", "fdt-lemans-evk-camera-csi1-imx577.dtbo"; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add the downstream camx overlay dtbo here (we are suffixing -camx) ?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The -camx suffix is added in compatible to be compared with the efivars. If a match is found, then the dtbo gets runtime overlayed by UEFI on top of the chosen DTB. As discussed earlier since this is upstream project, we are only adding dts/dtso which are present upstream. |
||
| }; | ||
| }; | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be good idea to add two dtdo names here.
for example for current testing an config entry that is being used is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will be updated in next patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I have pushed the new PR for our qcom-next overlay requirements:
#24
Pls review and let me know if this existing PR (#22) can be abandoned.