tests(bt_scan_pair): overhaul pairing logic and documentation #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smuppand
commented
Jul 16, 2025
smuppand
commented
- Unify direct- and fallback-pair loops into a single candidate iteration
- Consolidate scan→pair→connect→l2ping flow with retries (PAIR_RETRIES, SCAN_ATTEMPTS)
- Honor command-line args, BT_*_ENV variables, and bt_device_list.txt entries
- Add whitelist filtering by name or MAC (CLI arg or BT_WHITELIST_ENV)
- Ensure POSIX compliance: remove bashisms, quote variables, direct if‐command checks
- Improve bt_cleanup_paired_device to wrap expect in if-statement (no 0 checks)
- Replace SC2181 exit-code tests in retry_scan_and_pair with direct command tests
- Enhance README.md with usage examples, env-var overrides, script flow, and troubleshooting
- Unify direct- and fallback-pair loops into a single candidate iteration - Consolidate scan→pair→connect→l2ping flow with retries (PAIR_RETRIES, SCAN_ATTEMPTS) - Honor command-line args, BT_*_ENV variables, and bt_device_list.txt entries - Add whitelist filtering by name or MAC (CLI arg or BT_WHITELIST_ENV) - Ensure POSIX compliance: remove bashisms, quote variables, direct if‐command checks - Improve bt_cleanup_paired_device to wrap expect in if-statement (no 0 checks) - Replace SC2181 exit-code tests in retry_scan_and_pair with direct command tests - Enhance README.md with usage examples, env-var overrides, script flow, and troubleshooting Signed-off-by: Srikanth Muppandam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.