Skip to content

Camera_RDI_FrameCapture: stabilize RDI capture via parsed media-graph config + richer CI diagnostics #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Camera_RDI_FrameCapture: stabilize RDI capture via parsed media-graph config + richer CI diagnostics #166

merged 1 commit into from
Sep 15, 2025

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Sep 14, 2025 •
edited
Loading

This PR fixes #165

  • Keep original core flow & Python topology parser; no behavior changes to test logic.
  • Deterministic media-graph bring-up: apply parsed pad formats/links in order, normalize Bayer10 pads (*_1X10 → SRGGB10) without overriding video-node format.
  • One-shot media-ctl --reset and single auto-retry on failure; resolves intermittent “Broken pipe (32)” after reboot.
  • Stronger prechecks with check_kernel_config, module/builtin detection, and readable inventories of nodes/modules/sensors.
  • CI-friendly debug: banner with the planned sequence, log every executed media-ctl/yavta command, and capture dmesg snapshot (optional non-empty error logs).

@smuppand
(camera): harden Camera_RDI_FrameCapture with dynamic graph setup + C…
59e072f 
…I logs.

          Camera RDI capture was flaky after reboot and only passed when the media graph was configured manually.
          This change keeps the original pipeline parsing/flow intact while making the runner more robust and easier to debug.

Key changes:
  - Add clear banner: ----- Pipeline N: <sensor> <node> [pads:<mbus>] [video:<pixfmt>] -----
  - Print the exact commands that will run (for CI/debug):
    - media-ctl --reset, all -V pad formats (with runtime pixfmt), all -l links
  - yavta pre/post control writes and capture command (size, format, frames)
  - Do a light global media-ctl -r once before pipeline setup (matches manual flow)
  - Add a single automatic retry after a graph reset on first failure
  - Improve prechecks & visibility (non-gating except where noted):
  - Kernel config checks via existing check_kernel_config() for CONFIG_VIDEO_QCOM_CAMSS, CONFIG_MEDIA_CONTROLLER, CONFIG_V4L2_FWNODE
  - Best-effort CAMCC symbol discovery (name varies per tree)
  - Readiness gate accepts module/builtin/device nodes/dmesg evidence
  - Tidy output formatting (bullet lists for nodes/modules)

Signed-off-by: Srikanth Muppandam <[email protected]>
abbajaj806
abbajaj806 approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@abbajaj806 abbajaj806 merged commit e84268e into qualcomm-linux:main Sep 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbajaj806 abbajaj806 abbajaj806 approved these changes

@Vkenjam Vkenjam Awaiting requested review from Vkenjam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

camera Automation failing on Meta -qcom

2 participants

@smuppand @abbajaj806