Skip to content

Conversation

vkraleti
Copy link
Collaborator

@vkraleti vkraleti commented Oct 1, 2025

Add initial partition scheme, contents.xml template for IQ-9075-EVK, IQ-8275-EVK boards. Also add missing contents.xml template for QCS615-ADP-AIR board.

Fixes: #41

@lool
Copy link
Contributor

lool commented Oct 2, 2025

Could you close #41 with your first commit? (Use "fixes: #xyz" in the commit message)?

@ricardosalveti
Copy link
Contributor

# make sure generated output has created expected files
tests/integration/check-missing-files platforms/*/*/*.xml
Missing gpt_main5.bin referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing gpt_backup5.bin referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing rawprogram5.xml referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing patch5.xml referenced in platforms/qcs615-adp-air/ufs/contents.xml
make: *** [Makefile:34: integration] Error 1

@vkraleti
Copy link
Collaborator Author

vkraleti commented Oct 3, 2025

# make sure generated output has created expected files
tests/integration/check-missing-files platforms/*/*/*.xml
Missing gpt_main5.bin referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing gpt_backup5.bin referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing rawprogram5.xml referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing patch5.xml referenced in platforms/qcs615-adp-air/ufs/contents.xml
make: *** [Makefile:34: integration] Error 1

This failure is little surprising. Exact same schema working fine on qcs6490-rb3gen2 platform. Seems ptool is generating an unwanted gpt entry. Will investigate and get back.

@lumag
Copy link
Contributor

lumag commented Oct 3, 2025

# make sure generated output has created expected files
tests/integration/check-missing-files platforms/*/*/*.xml
Missing gpt_main5.bin referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing gpt_backup5.bin referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing rawprogram5.xml referenced in platforms/qcs615-adp-air/ufs/contents.xml
Missing patch5.xml referenced in platforms/qcs615-adp-air/ufs/contents.xml
make: *** [Makefile:34: integration] Error 1

This failure is little surprising. Exact same schema working fine on qcs6490-rb3gen2 platform. Seems ptool is generating an unwanted gpt entry. Will investigate and get back.

It's not that surprising. Somebody has hardcoded into qcom-ptool that UFS devices have LUNs 0-5. I've stumbled upon that while being at XDC, but I didn't have time to fix it. Please adjust qcom-ptool not to write unused LUNs to partition.xml

ndechesne added a commit to ndechesne/qcom-ptool that referenced this pull request Oct 3, 2025
gen_partition.py assumes there can be up to 5 LUNs, and generate an
XML file with 5 physical_partition entries. For QCS615, there are only
4 LUNs, and we end up generating partitions.xml with an extra, empty
physical_partition entry.

The right thing would probably be to parse partition.conf and detect
how many LUNs we have in there, but a simpler solution is to keep
trying 5 LUNs but only create the physical_partition entry once we
find at least one partition, which is what this patch does. It should
fix the problem we've noticed in qualcomm-linux#42.

Signed-off-by: Nicolas Dechesne <[email protected]>
Add contents.xml template for both emmc and ufs storage types of
qcs615-adp-air board.

Signed-off-by: Viswanath Kraleti <[email protected]>
Add initial partition scheme, contents.xml template for IQ-9075-EVK board

Signed-off-by: Viswanath Kraleti <[email protected]>
Add initial partition scheme, contents.xml template for IQ-8275-EVK board

Signed-off-by: Viswanath Kraleti <[email protected]>
@lumag lumag merged commit 251d9b4 into qualcomm-linux:main Oct 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No contents.xml.in for qcs615

4 participants