refactor: replace boto3-based upload with AWS CLI

[quic-viskuma]

Simplifies the artifact upload process by removing Python dependencies and switching to AWS CLI.

• Deleted publish_artifacts.py and requirements.txt
• Updated action.yml to use aws s3 cp for uploading artifacts
• Ensures compatibility with both Ubuntu and Debian environments

Fixes: #9

[lool]

Looks good to me, thanks!

I see the unit tests ran, but against the main version of the action which uploads to GCP; I'll file a separate issue for that

[lool]

@quic-viskuma If you add Fixes: #9 to your commit, it will automatically close the issue when your commit gets merged

[doanac]

looks good. this requires the workflow to run as root when aws-cli isn't installed. I think this is the case for our workflows, right?

[lool]

looks good. this requires the workflow to run as root when aws-cli isn't installed. I think this is the case for our workflows, right?

I think we run as non-root on the runners, and as root in the containers; our images seem to have aws pre-installed. So this code should run in both cases (and I believe was tested for both cases).

One possible improvement would be to use sudo to apt install when running as non-root, but I guess it's not really a situation we're expecting to be in for this qualcomm specific action, so perhaps we can defer until we hit it? Same for non-deb/apt based OSes.

[quic-viskuma]

looks good. this requires the workflow to run as root when aws-cli isn't installed. I think this is the case for our workflows, right?

I think we run as non-root on the runners, and as root in the containers; our images seem to have aws pre-installed. So this code should run in both cases (and I believe was tested for both cases).

One possible improvement would be to use sudo to apt install when running as non-root, but I guess it's not really a situation we're expecting to be in for this qualcomm specific action, so perhaps we can defer until we hit it? Same for non-deb/apt based OSes.

Yes, I have tested with AWS runners which we're using in our workflows and also with containers. I'm not sure if we should add sudo while installing, I can test this. We also need to consider the other OSes- like fedora in future.

[lool]

Let's land this now and add support for Fedora when that comes?

[doanac]

I've merged this and tagged it as aws-v2