-
Notifications
You must be signed in to change notification settings - Fork 113
Fix #1191 - refactor CredentialsProvider return type #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ricardozanini
merged 3 commits into
quarkiverse:main
from
gabriel-farache:fix_CredentialsProvider_return_optionnal
Jun 18, 2025
Merged
Fix #1191 - refactor CredentialsProvider return type #1192
ricardozanini
merged 3 commits into
quarkiverse:main
from
gabriel-farache:fix_CredentialsProvider_return_optionnal
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@wmedvede PTAL |
...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java
Dismissed
Show dismissed
Hide dismissed
ricardozanini
approved these changes
Jun 12, 2025
wmedvede
requested changes
Jun 13, 2025
Contributor
wmedvede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gabriel-farache I have left some comments, take a look it makes sense please.
...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/quarkiverse/openapi/generator/providers/ApiKeyAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...me/src/main/java/io/quarkiverse/openapi/generator/providers/BasicAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/quarkiverse/openapi/generator/providers/BearerAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java
Show resolved
Hide resolved
.../main/java/io/quarkiverse/openapi/generator/oidc/providers/OAuth2AuthenticationProvider.java
Show resolved
Hide resolved
.../main/java/io/quarkiverse/openapi/generator/oidc/providers/OAuth2AuthenticationProvider.java
Show resolved
Hide resolved
f521b8a to
8006c30
Compare
Signed-off-by: gabriel-farache <[email protected]>
8006c30 to
20397b8
Compare
Signed-off-by: gabriel-farache <[email protected]>
f17b39c to
994d161
Compare
wmedvede
reviewed
Jun 18, 2025
...e/src/main/java/io/quarkiverse/openapi/generator/providers/ApiKeyAuthenticationProvider.java
Show resolved
Hide resolved
wmedvede
approved these changes
Jun 18, 2025
ricardozanini
approved these changes
Jun 18, 2025
ricardozanini
pushed a commit
to ricardozanini/quarkus-openapi-generator
that referenced
this pull request
Jun 18, 2025
…kiverse#1192) * Fix quarkiverse#1191 - refactor CredentialsProvider return type * Apply feedback Signed-off-by: gabriel-farache <[email protected]> * Better log message for oauth2 provider Signed-off-by: gabriel-farache <[email protected]> --------- Signed-off-by: gabriel-farache <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1191
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.