-
Notifications
You must be signed in to change notification settings - Fork 113
Added so equals and hashcode is generated in models. #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fjtirado
merged 9 commits into
quarkiverse:main
from
denvitaharen:feature/add-equals-hashcode-client
Dec 23, 2024
Merged
Added so equals and hashcode is generated in models. #920
fjtirado
merged 9 commits into
quarkiverse:main
from
denvitaharen:feature/add-equals-hashcode-client
Dec 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
I realized that I hadn't written any javadoc for the new methods, so I added it now. It took some inspiration from the String and Long javadoc and rewrote so it fits this in. |
|
Excellent, I really need equal/hashcode |
ricardozanini
approved these changes
Dec 19, 2024
Member
ricardozanini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hbelmiro
reviewed
Dec 20, 2024
.../equals-hashcode/src/test/java/io/quarkiverse/openapi/generator/it/VerifyGenerationTest.java
Outdated
Show resolved
Hide resolved
client/deployment/src/main/resources/templates/libraries/microprofile/pojo.qute
Outdated
Show resolved
Hide resolved
mcruzdev
reviewed
Dec 20, 2024
Co-authored-by: Matheus Cruz <[email protected]>
…nt' into feature/add-equals-hashcode-client
hbelmiro
reviewed
Dec 21, 2024
.../equals-hashcode/src/test/java/io/quarkiverse/openapi/generator/it/VerifyGenerationTest.java
Show resolved
Hide resolved
hbelmiro
approved these changes
Dec 23, 2024
mcruzdev
approved these changes
Dec 23, 2024
fjtirado
approved these changes
Dec 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
…-client Added so equals and hashcode is generated in models.
7 tasks
hbelmiro
pushed a commit
that referenced
this pull request
Dec 23, 2024
…-client Added so equals and hashcode is generated in models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectI have added so
equalsandhashCodeis generated to the models. It's possible to disabled it if someone doesn't want it.@ricardozanini I created an new branch and pull request, it was easier and faster for me to do that.
The result looks like this: