Skip to content

Added so equals and hashcode is generated in models. #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 23, 2024
Merged

Added so equals and hashcode is generated in models. #920

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
773177c
Added so equals and hashcode is generated in models.
denvitaharen Dec 18, 2024
9e302e4
Added extra empty row between toString and equals
denvitaharen Dec 18, 2024
a5cd95b
Updated the documentation
denvitaharen Dec 18, 2024
3d02cc2
Added javadoc to the equals and hashcode methods
denvitaharen Dec 18, 2024
ac665fe
Update docs/modules/ROOT/pages/includes/equals-hashcode.adoc
denvitaharen Dec 20, 2024
53db5f9
Changed so we use FCQN instead of importin java.util.Objects.
denvitaharen Dec 20, 2024
0072fac
Merge remote-tracking branch 'origin/feature/add-equals-hashcode-clie…
denvitaharen Dec 20, 2024
cd63c11
Refactored VerifyGenerationTest so it tests the generation better.
denvitaharen Dec 20, 2024
5121a39
Corrected name of methods in VerifyGenerationTest.
denvitaharen Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions ...uals-hashcode/src/test/java/io/quarkiverse/openapi/generator/it/VerifyGenerationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,37 @@
package io.quarkiverse.openapi.generator.it;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;

import java.lang.reflect.Method;
import java.util.Arrays;
import java.util.stream.Stream;

import org.acme.non.equals.hashcode.model.Animal;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
import org.junit.jupiter.api.Test;

import io.quarkus.test.junit.QuarkusTest;

@QuarkusTest
class VerifyGenerationTest {

@ParameterizedTest
@MethodSource("provideStringsForIsBlank")
void verify(Class<?> clazz, String methodName, Class<?> expectedDeclaringClass) {
var equalsMethod = getMethod(clazz, methodName);
@Test
void verifyThatGeneratedModelDoesntHaveMethods() {
var equalsMethod = getMethod(org.acme.equals.hashcode.model.Animal.class, "equals");
var hashCodeMethod = getMethod(org.acme.equals.hashcode.model.Animal.class, "hashCode");

Class<?> declaringClass = equalsMethod.getDeclaringClass();

assertEquals(declaringClass, expectedDeclaringClass);
assertEquals(equalsMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
assertEquals(hashCodeMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
}

private static Stream<Arguments> provideStringsForIsBlank() {
return Stream.of(
Arguments.of(Animal.class, "equals", Object.class),
Arguments.of(Animal.class, "hashCode", Object.class),
Arguments.of(org.acme.equals.hashcode.model.Animal.class, "equals",
org.acme.equals.hashcode.model.Animal.class),
Arguments.of(org.acme.equals.hashcode.model.Animal.class, "hashCode",
org.acme.equals.hashcode.model.Animal.class));
@Test
void verifyThatGeneratedModelDoesHaveMethods() {
var equalsMethod = getMethod(org.acme.non.equals.hashcode.model.Animal.class, "equals");
var hashCodeMethod = getMethod(org.acme.non.equals.hashcode.model.Animal.class, "hashCode");

assertNotEquals(equalsMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
assertNotEquals(hashCodeMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
}

public static Method getMethod(Class<?> clazz, String methodName) {
private static Method getMethod(Class<?> clazz, String methodName) {
var methods = clazz.getMethods();

return Arrays.stream(methods)
Expand Down
Loading