Skip to content

Conversation

@ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Jan 17, 2025

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Closes #940

WIP:

  • - Review unit test in runtime module to use QuarkusTestProfile
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini ricardozanini added area:client This item is related to the client extension backport-main-lts labels Jan 17, 2025
@ricardozanini
Copy link
Member Author

cc @quarkiverse/quarkiverse-openapi-generator

@ricardozanini ricardozanini marked this pull request as ready for review January 17, 2025 23:21
@ricardozanini ricardozanini requested a review from a team as a code owner January 17, 2025 23:21
@ricardozanini ricardozanini changed the title Fix #940 - Change authorization properties configuration to RUNTIME WIP - Fix #940 - Change authorization properties configuration to RUNTIME Jan 17, 2025
@ricardozanini ricardozanini changed the title WIP - Fix #940 - Change authorization properties configuration to RUNTIME Fix #940 - Change authorization properties configuration to RUNTIME Jan 20, 2025
Signed-off-by: Ricardo Zanini <[email protected]>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just 2 nits.

Signed-off-by: Ricardo Zanini <[email protected]>
@ricardozanini ricardozanini merged commit f6a217c into quarkiverse:main Jan 21, 2025
7 checks passed
@ricardozanini ricardozanini deleted the issue-940 branch January 21, 2025 14:43
github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
…943)

* Fix #940 - Change authorization properties configuration to RUNTIME

Signed-off-by: Ricardo Zanini <[email protected]>

* Add generated configuration properties

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix runtime unit tests

Signed-off-by: Ricardo Zanini <[email protected]>

* Incorporating @mcruzdev's review

Signed-off-by: Ricardo Zanini <[email protected]>

* incorporating @hbelmiro's review

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
hbelmiro pushed a commit that referenced this pull request Jan 21, 2025
…943) (#952)

* Fix #940 - Change authorization properties configuration to RUNTIME



* Add generated configuration properties



* Fix runtime unit tests



* Incorporating @mcruzdev's review



* incorporating @hbelmiro's review



---------

Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:client This item is related to the client extension backport-main-lts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration can't be updated at runtime

3 participants