-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Jakarta Data quickstart #1516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jakarta Data quickstart #1516
Conversation
92e54b9 to
35c4cea
Compare
hibernate-orm-jakarta-data-quickstart/src/main/docker/Dockerfile.legacy-jar
Outdated
Show resolved
Hide resolved
hibernate-orm-jakarta-data-quickstart/src/main/java/org/acme/hibernate/orm/Fruit.java
Outdated
Show resolved
Hide resolved
hibernate-orm-jakarta-data-quickstart/src/main/java/org/acme/hibernate/orm/Fruit.java
Outdated
Show resolved
Hide resolved
hibernate-orm-jakarta-data-quickstart/src/main/java/org/acme/hibernate/orm/FruitRepository.java
Outdated
Show resolved
Hide resolved
hibernate-orm-jakarta-data-quickstart/src/main/java/org/acme/hibernate/orm/FruitResource.java
Outdated
Show resolved
Hide resolved
hibernate-orm-jakarta-data-quickstart/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
35c4cea to
a890883
Compare
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM, but it's still a draft? Is there still something missing?
|
hey 👋🏻
Other than that ... 🟢 😃 |
It's in.
The best practice is to use
He suggested to remove it, IIRC? Or at least replace it with just a title + link to docs. Fine by me, but should be a separate PR that would need to address all Hibernate quickstarts. So it's fine to merge your PR as is. So... merging :) |
|
@marko-bekhta Did you link to this quickstart from the Quarkus docs? You probably should, otherwise nobody will notice it :) |
thanks for the suggestion 😃 will send a PR later 👍🏻 |
Check list:
Your pull request:
developmentbranch999-SNAPSHOTversion of Quarkusmvn clean test)mvn clean package -Pnative)mvn clean verify -Pnative)README.mdfile (with build and run instructions)pom.xmlandREADME.md