Skip to content

Conversation

@yrodiere
Copy link
Member

@yrodiere yrodiere commented Nov 8, 2024

Supersedes #44378, #44386

Fixes #7462
Fixes #43056
Fixes #43296
Fixes #44454

Creating as draft since Hibernate ORM 6.6.3.Final hasn't been released yet.

We can't really upgrade to Hibernate ORM 6.6.2.Final, because the fix for HHH-16572 is causing problems, failing one test and more importantly probably breaking some user applications with unclear error messages -- possibly at runtime.

We decided to work on the following fixes/improvement in ORM, and upgrade to 6.6.3.Final directly, assuming they get merged in that release:

NOTE: HHH-16572 introduces a check for whether bytecode enhancement is supported for a given class. If that check is not reliable enough, we might want to change io.quarkus.hibernate.orm.deployment.integration.QuarkusEnhancementContext#getUnsupportedEnhancementStrategy to return LEGACY -- which would revert to the (dangerous, but backwards-compatible) behavior from Hibernate ORM 6.6.1.Final and earlier. I'm thinking about Quarkus 3.15 LTS in particular -- though we'll have to balance the danger of that earlier behavior against the danger of the check being unreliable.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 8, 2024

/cc @gsmet (hibernate-orm)

@yrodiere yrodiere requested a review from beikov November 22, 2024 15:59
@yrodiere yrodiere added the triage/needs-review Issue that needs a review - remove label if all is clear label Nov 22, 2024
@yrodiere yrodiere added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed triage/needs-review Issue that needs a review - remove label if all is clear labels Nov 22, 2024
@yrodiere
Copy link
Member Author

yrodiere commented Nov 22, 2024

Thanks for the review.

@gsmet note I created a PR for the backport, with a small change in the "unsupported enhancement strategy": #44658

EDIT: Actually this will be #44703

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b827df5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - History

  • INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException
io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:631)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testStreamingOutputCall(VirtualThreadTestBase.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:967)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:817)

@gsmet gsmet merged commit b3a893c into quarkusio:main Nov 23, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 23, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 23, 2024
@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed kind/bugfix labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM triage/flaky-test triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

3 participants