Skip to content

Tidy switch of Oracle tests to dev services #51065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −93
Open

Tidy switch of Oracle tests to dev services #51065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions integration-tests/hibernate-reactive-oracle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,35 +166,6 @@
</build>
</profile>

<profile>
<id>docker-oracle</id>
<activation>
<property>
<name>start-containers</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
<execution>
<id>docker-prune</id>
<phase>generate-resources</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>${docker-prune.location}</executable>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

<!-- Disabled pending fix of #33094 -->
<profile>
<id>podman</id>
Expand Down
6 changes: 3 additions & 3 deletions integration-tests/jpa-oracle/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Running the tests


To run the tests in a standard JVM with an Oracle database started as a Docker container, you can run the following command:
To run the tests in a standard JVM with an Oracle database started as a Dev Service, you can run the following command:

```
mvn verify -Dtest-containers -Dstart-containers
Expand All @@ -17,13 +17,13 @@ mvn verify -Dtest-containers -Dstart-containers -Dnative

Alternatively you can connect to your own Oracle database.
Reconfigure the connection URL with `-Doracledb.url=jdbc:Oracle://...`;
Authentication parameters might need to be changed in the Quarkus configuration file `application.properties`.
Authentication parameters might need to be added in the Quarkus configuration file `application.properties`.

### Starting Oracle via docker

```
docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23-slim-faststart
```

This will start a local instance with the configuration matching the parameters used by the integration tests of this module.
This will start a local instance. Update `application.properties` with the new configuration.

29 changes: 0 additions & 29 deletions integration-tests/jpa-oracle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,35 +174,6 @@
</plugins>
</build>
</profile>

<profile>
<id>docker-oracle</id>
<activation>
<property>
<name>start-containers</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
<execution>
<id>docker-prune</id>
<phase>generate-resources</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>${docker-prune.location}</executable>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>
8 changes: 4 additions & 4 deletions integration-tests/reactive-oracle-client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Reactive Oracle example


## Running the tests

By default, the tests of this module are disabled.

To run the tests in a standard JVM with an Oracle database started as a Docker container, you can run the following command:
To run the tests in a standard JVM with an Oracle database started as a Dev Service, you can run the following command:

```
mvn verify -Dtest-containers -Dstart-containers
Expand All @@ -18,12 +18,12 @@ mvn verify -Dtest-containers -Dstart-containers -Dnative

Alternatively you can connect to your own Oracle database.
Reconfigure the connection URL with `-Dreactive-oracledb.url=jdbc:oracle:thin:...`;
Authentication parameters might need to be changed in the Quarkus configuration file `application.properties`.
Authentication parameters might need to be added in the Quarkus configuration file `application.properties`.

### Starting Oracle via docker

```
docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23-slim-faststart
```

This will start a local instance with the configuration matching the parameters used by the integration tests of this module.
This will start a local instance. Update `application.properties` with the new configuration.
28 changes: 0 additions & 28 deletions integration-tests/reactive-oracle-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,34 +140,6 @@
</plugins>
</build>
</profile>
<profile>
<id>docker-oracle</id>
<activation>
<property>
<name>start-containers</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
<execution>
<id>docker-prune</id>
<phase>generate-resources</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>${docker-prune.location}</executable>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>
Loading