Skip to content

Conversation

@holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Nov 17, 2025

Ah, there's nothing like having a PR merged and moving on the next task to help you spot all the problems with the PR. :)

This is a follow-on to #51059. I realised I needed to update the readmes now that dev services are being used. I also noticed that while the start-containers maven profile has content, the content is only an invocation of .github/docker-prune, which is a no-op everywhere but windows CI. #35458 disabled it because it was causing more problems than it was fixing.

Adding @famod and @geoand for review, since they added the original scripts. I think we don't need to do a docker prune if we're using testcontainers, even on Windows, but they may have scars that say otherwise. :)

@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Nov 17, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 17, 2025

/cc @gsmet (hibernate-orm)

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Nov 18, 2025

but they may have scars that say otherwise

If I did, my brain has repressed them :)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a minor typo.

@holly-cummins
Copy link
Contributor Author

@yrodiere points out we don't run containers on Windows CI, so the Windows of the prune script also can't ever be doing anything. (It could prune locally, maybe, except we have a guard saying pruning should only happen on CI, because otherwise running a build would be taking a machete to local container setups and cause mayhem.)

@holly-cummins holly-cummins force-pushed the tidy-oracle-tests-using-devservices branch from faf2604 to 33ca1bb Compare November 18, 2025 10:55
@holly-cummins
Copy link
Contributor Author

Accepted and squashed, thanks @gsmet! But accepted on condition that you laugh at the lame joke I made in the review thread.

@holly-cummins holly-cummins requested a review from gsmet November 18, 2025 10:57
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 18, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 33ca1bb.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@yrodiere yrodiere removed their request for review November 19, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants