-
Notifications
You must be signed in to change notification settings - Fork 3k
Tidy switch of Oracle tests to dev services #51065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tidy switch of Oracle tests to dev services #51065
Conversation
|
/cc @gsmet (hibernate-orm) |
This comment has been minimized.
This comment has been minimized.
If I did, my brain has repressed them :) |
gsmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a minor typo.
|
@yrodiere points out we don't run containers on Windows CI, so the Windows of the prune script also can't ever be doing anything. (It could prune locally, maybe, except we have a guard saying pruning should only happen on CI, because otherwise running a build would be taking a machete to local container setups and cause mayhem.) |
Co-Authored-By: Guillaume Smet <[email protected]>
faf2604 to
33ca1bb
Compare
|
Accepted and squashed, thanks @gsmet! But accepted on condition that you laugh at the lame joke I made in the review thread. |
Status for workflow
|
Ah, there's nothing like having a PR merged and moving on the next task to help you spot all the problems with the PR. :)
This is a follow-on to #51059. I realised I needed to update the readmes now that dev services are being used. I also noticed that while the
start-containersmaven profile has content, the content is only an invocation of.github/docker-prune, which is a no-op everywhere but windows CI. #35458 disabled it because it was causing more problems than it was fixing.Adding @famod and @geoand for review, since they added the original scripts. I think we don't need to do a docker prune if we're using testcontainers, even on Windows, but they may have scars that say otherwise. :)