Skip to content

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Sep 16, 2024

This fix MECA bundle problem in project with special filename

closes quarto-ext/manuscript-template-rstudio#3

…cters (like space)

- Fix MECA bundle problem in project with special filename
@cscheid
Copy link
Collaborator

cscheid commented Sep 16, 2024

If we're going to go fix this, let's also handle the extra weird case where the file-name has double quotes in it (which I think will break your code...)

@cderv
Copy link
Collaborator Author

cderv commented Sep 16, 2024

the extra weird case where the file-name has double quotes in it (which I think will break your code...)

I considered it extra weird indeed and thought that this would not be needed because " is not allowed in windows file name and path. We are in a Powershell command here, so windows only and this use case won't happen AFAIU.

Do you really want to try handle it ?

Docs from microsoft: https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#win32-file-namespaces

Use any character in the current code page for a name, including Unicode characters and characters in the extended character set (128–255), except for the following:

The following reserved characters:

  • < (less than)
  • > (greater than)
  • : (colon)
  • " (double quote)
  • / (forward slash)
  • \ (backslash)
  • | (vertical bar or pipe)
  • ? (question mark)
  • * (asterisk)

@cscheid
Copy link
Collaborator

cscheid commented Sep 16, 2024

(TIL!) If double quotes are illegal on Windows, then this PR is ready to go!

@cderv cderv merged commit af5363e into main Sep 17, 2024
47 checks passed
@cderv cderv deleted the fix/windows/meca-bundle branch September 17, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quarto render with jats set to default issue

2 participants