Skip to content

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Oct 11, 2024

This will prevent test not running without us knowing like the one I just added.

cderv added 2 commits October 11, 2024 15:56
…rto.test` (without s)

This will prevent test not running without us knowing
@cscheid
Copy link
Collaborator

cscheid commented Oct 11, 2024

We could do this in our YAML validation...

@cderv
Copy link
Collaborator Author

cderv commented Oct 11, 2024

Indeed. I assumed we did not have validation for our special _quarto field. Have we ?

Or are you suggesting we add some ?
I think we should have but I aimed for a simple fix with PR.

Maybe that is easy to add.

@cscheid
Copy link
Collaborator

cscheid commented Oct 11, 2024

You don't need to change anything, and we don't currently have it. But if we did, it would prevent this and other mistakes. More generally, checking on validation is preferred than "at render time", because it's a more general solution. It's the same principle as using types in Typescript instead of runtime type validation.

@cderv
Copy link
Collaborator Author

cderv commented Oct 11, 2024

Great. Totally agree. We should definitely have validation for this _quarto field. I'll keep that in mind.

This is indeed very ugly way to do it as it throw an uncaught error better than nothing to at least not reproduce my previous mistake of test not being run.

Thanks !

@cderv cderv merged commit 52d5a6e into main Oct 11, 2024
47 checks passed
@cderv cderv deleted the tests/smoke-all-check branch October 11, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants