-
Notifications
You must be signed in to change notification settings - Fork 383
Improve SCSS in Revealjs - Part 2 : Callouts #11251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a14b58d
to
20b6b89
Compare
So that it applies also in non bootstrap like revealjs
Same as in bootstrap file as loaded in the `_quarto-uses.scss` file layer for all HTML format. This simplifies understanding and make it more coherent with the rest of the Quarto styles.
- Move callouts style in SCSS to make them configurable - Use same color as bootstrap HTML - Make SCSS more coherent with the one used in Bootstrap - Remove using styles-callout.html for revealjs. Only keep it for epub
This allows to group common rule, and see patterns.
This is because supposedly hidden background color will show
It is coming from styles-callout.html and it overriden by revealjs specific
As space is more limited in revealjs This match current behavior in quarto 1.5 too
This is improvement over quarto 1.5
This insure when .smaller is applied, it stays visually nice
and remove duplicate from previous PR
So I think we are missing some structure in the HTML that would require to modify the Lua filter for revealjs. We need a wrapper for the flex display, so that we can apply I don't want to handle that in same PR as this is about style. And maybe we'll want to push to 1.7 instead for this fix - I am not sure about touching the Lua filter this late. |
This was
linked to
issues
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on Callouts
styles-callout.html
has been integrated for Revealjs into quarto.scss. This way SCSS variable can be used to tweak callouts.This goes with SCSS refactoring to
Callouts in Revealjs has been made closer looking to the one in Boostrap
It also solves some issues
div.sourceCode
when it is last element of Callout. A duplicated color was shown.div.sourceCode
is last element of simple style callout, there was border merging. Some margin have been addedThe new looks can be found at https://examples.quarto.pub/revealjs-default-callouts-styles/
Not easy to compare, but everything should be good looking.
I used this presentation to check visually that new SCSS gives same results a current version. If anything seems odd to any of you, please tell me.
Opening as a draft, as I need to run a few more examples and checks