Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
c22c30f
Move rule from boostrap only to quarto
cderv Oct 28, 2024
d5634d0
sass - use same quarto- color namespace for sass:color
cderv Oct 28, 2024
5e0ebec
callout, revealjs - better callouts
cderv Oct 28, 2024
a477fa8
Try to improve icon placement in callouts
cderv Oct 29, 2024
d74def4
Refactor SCSS in nested structure
cderv Oct 30, 2024
7e1a03e
Move every rule for callouts inside div.callout
cderv Oct 30, 2024
33ba3e3
Refactor as nested structure the callout type part too
cderv Oct 30, 2024
0874e7c
Move every callouts Style rules in same place
cderv Oct 30, 2024
a353619
Move common rule in same place
cderv Oct 30, 2024
9114212
Font size for callouts in revealjs is set by scalling down like smaller
cderv Oct 30, 2024
9c7c32b
simple and default style share more common rules
cderv Oct 30, 2024
2073f2c
Organize all div together
cderv Oct 30, 2024
1f17e51
specific font size should not apply on title
cderv Oct 30, 2024
71caa92
Don't apply padding on last element if it is a highlited div
cderv Oct 30, 2024
ea4ef90
Set correct specificity on callout type rules
cderv Oct 30, 2024
ab921ad
This is not suppose to apply in revealjs
cderv Oct 30, 2024
f0e6f72
Use less margin in revealjs than in bootstrap
cderv Oct 30, 2024
ce22be2
Add some margin if code block is last element
cderv Oct 30, 2024
67165ba
Compute icon size based on context
cderv Oct 30, 2024
e58aa91
Use em for other type of callouts too
cderv Oct 31, 2024
fa4051a
Move variable related to brand.yml together
cderv Nov 4, 2024
732974f
Merge identical rule
cderv Nov 5, 2024
83d6ba2
Regroup duplicated rule together
cderv Nov 5, 2024
3a6bdee
duplicated rule unecessary
cderv Nov 5, 2024
a35aa94
Use revealjs --r-block-margin variable for last element margin
cderv Nov 5, 2024
b6a8b14
Unused rule as already defined for both styles default and simple
cderv Nov 5, 2024
5c88821
Move rule with others
cderv Nov 5, 2024
9ea52f3
No `.callout-header` in Revealjs
cderv Nov 5, 2024
1381661
move last rule in common styles rules
cderv Nov 5, 2024
73e3086
Ensure same top block margin for untitle callout content
cderv Nov 5, 2024
a0672b1
Only simple style callout can be non titled
cderv Nov 5, 2024
6728fcf
Add some comments to understand to what the rules apply
cderv Nov 5, 2024
3072cb2
Add changelog entry for all these improvements
cderv Nov 5, 2024
aaa4639
Add test to check SCSS color customization for callouts
cderv Nov 6, 2024
66df087
regroup helper in utils file
cderv Nov 6, 2024
30d31ac
Also check border wdith customization
cderv Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions news/changelog-1.6.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ All changes included in 1.6:
- Update to Reveal JS 5.1.0.
- Support for a [Jump To Slide](https://revealjs.com/jump-to-slide/) menu to quickly navigate between slides. Set `jump-to-slide: false` to opt out.
- Support for new [Scroll View](https://revealjs.com/scroll-view/) mode with configuration through new `scroll-view` revealjs's format configuration key. A new menu tool has been added to toggle scroll view mode on and off, associated with `R` key by default.
- Styles improvements for Callouts in Revealjs:
- SCSS variables can be used to customize the appearance of callouts in Revealjs. The following SCSS variables are available:
- Border width and scale (`$callout-border-width`, `$callout-border-scale`)
- Border colors (`$callout-color-note`, `$callout-color-tip`, `$callout-color-important`, `$callout-color-caution`, `$callout-color-warning`)
- Margins (`$callout-margin-top`, `$callout-margin-bottom`)
- Color for each callout type is now the same as in Bootstrap document `format: html`. This allows for consistent styling across formats. If you prefer other colors, you can override using the new SCSS variables
- Icon for each callout type is now using SVG like in Bootstrap document `format: html`. This allows for consistent styling across formats.
- Callouts looks better in slides made smaller and when containing code blocks.
- To see how callouts looks like in revealjs, see this example: <https://examples.quarto.pub/revealjs-default-callouts-styles>
- Prevent empty SASS built css file to be included in header.
- Remove wrong `sourceMappingUrl` entry in SASS built css.
- ([#7715](https://github.com/quarto-dev/quarto-cli/issues/7715)): Revealjs don't support anymore special Pandoc syntax making BulletList in Blockquotes become incremental list. This was confusing and unexpected behavior. Supported syntax for incremental list is documented at <https://quarto.org/docs/presentations/revealjs/#incremental-lists>.
Expand Down
1 change: 0 additions & 1 deletion src/format/reveal/format-reveal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ export function revealjsFormat() {
metadataOverride,
templateContext,
[kIncludeInHeader]: [
formatResourcePath("html", "styles-callout.html"),
stylesFile,
],
html: {
Expand Down
6 changes: 6 additions & 0 deletions src/resources/formats/html/_quarto-rules.scss
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,12 @@ a {
text-underline-offset: 3px;
}

/* Callout styling */

.callout pre.sourceCode {
padding-left: 0;
}

// ansi escaping
div.ansi-escaped-output {
font-family: monospace;
Expand Down
5 changes: 0 additions & 5 deletions src/resources/formats/html/bootstrap/_bootstrap-rules.scss
Original file line number Diff line number Diff line change
Expand Up @@ -885,11 +885,6 @@ pre.sourceCode > code.sourceCode {
}
}

// no border inside callouts
.callout pre.sourceCode {
padding-left: 0;
}

div.sourceCode {
overflow-y: hidden;
}
Expand Down
Loading
Loading