-
Notifications
You must be signed in to change notification settings - Fork 391
Support colour output in stdout for jupyter and julia engines
#12132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support colour output in stdout for jupyter and julia engines
#12132
Conversation
|
Still to add some tests and update the changelog. I'll do that once I've familiarised myself with https://github.com/quarto-dev/quarto-cli/blob/main/tests/README.md |
|
@MichaelHatherly The easiest way to add tests is, by far, to use the In our test suite, every document inside For the example above, the behavior is very simple: it's asking for the HTML format output to respect a given regex. Checking in a document with this syntax is enough for our test suite to run it, but during development there is a more convenient option. If you're running a dev build of quarto, you should have a In this test, we're asking the test suite to fail if the Some example checkers:
The full suite isn't document but is at |
|
Thank you for those details @cscheid, very helpful! |
|
Looks to me like that single failed test is unrelated. @cscheid does that seem correct to you? |
|
I triggered a re-run of failing test to check as this was passing on Linux but not on Windows. Sometimes this means transient error . |
|
I triggered a re-run of failing test to check as this was passing on Linux but not on Windows. Sometimes this means transient error . Thanks, yes, looks like it was a transient one. |
|
Looks great, thank you! |
Description
This adds support for printing colour output from stdout and stderr in the
jupyterandjuliabackends. Only applies to HTML output.Fixes #12117.
Checklist
I have (if applicable):