Feature: cell renderings, light and dark #12277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwoodhull
force-pushed
the
feature/cell-light-dark-renderings
branch
2 times, most recently
from
434487f to
0ed3bf1
Compare
gordonwoodhull
changed the title
Contributor
Author
|
It's not as easy as I thought to detect captions and labels, due to the same complexities that make them difficult to handle properly. I think it could be done succinctly with walks, but I will leave it out and document it for now. You'll get this warning for the cross-refs, letting you know that the expected No warning for the caption, but it will only show in light mode. |
gordonwoodhull
force-pushed
the
feature/cell-light-dark-renderings
branch
from
0ed3bf1 to
be24adb
Compare
gordonwoodhull
force-pushed
the
feature/cell-light-dark-renderings
branch
from
be24adb to
587dbbc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
gordonwoodhull
force-pushed
the
feature/cell-light-dark-renderings
branch
from
587dbbc to
d59b6d3
Compare
a filter to detect e.g. renderings: [light, dark] retain any cell content before the first cell-output-display then any div.cell-output-display are given the rendering names formats choose what to do with these in the filter currently HTML uses light and dark and classes them .light-content and .dark-content and the other formats just use light rendering applies body.quarto-light or body.quarto-dark based on default theme for a decent NoJS experience
gordonwoodhull
force-pushed
the
feature/cell-light-dark-renderings
branch
from
d59b6d3 to
e90cddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the cell attribute
If the cell contains two
div.cell-output-display, the content will be put in adiv.light-contentand adiv.dark-contentinstead.Then
.dark-contentis hidden whenbodyhas.quarto-light, and vice-versa.To do:
Warn if caption or label on the same cell, as they won't work righthas_renderingsflag inflags.luaand check inmain.lua.quarto-darkinstead of.quarto-lightif dark theme is default