fix wrong ordering of highlighting stylesheets for dark mode, and also nojs highlight bleeding #12523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwoodhull
force-pushed
the
bugfix/layer-highlight-light-dark-light
branch
from
534a02a to
c902253
Compare
gordonwoodhull
changed the title
these test some elements we saw bad behavior in nojs mode also, a rather more severe bug where light highlighting is being applied
this fixes the light syntax highlighting being applied in dark mdoe since we are no longer disabling the light stylesheet use the same light, dark, light pattern as the main stylesheet
gordonwoodhull
force-pushed
the
bugfix/layer-highlight-light-dark-light
branch
from
c902253 to
113e809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a very bad bug with syntax highlighting in dark mode
This is because we no longer disable the light highlight stylesheet due to honoring the dark = light + dark convention.
The last commit in this PR fixes this by following the light, dark, light stylesheet pattern we are following for the main stylesheet.
I prefer this because it is consistent with our old behavior (except in nojs) and the other stylesheet. However, if others prefer a simpler approach, we could handle this case differently and disable the light highlight stylesheet instead.
The first commit is the tests, which fail on their own.
The second commit is the fixes to the highlighting styles, so that dark + light does not have the artifacts we saw for arrow, a11y
fixes #12399
fixes #12522