Skip to content

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Aug 28, 2025

Possibly related to a change in fs-extra so trying to pin a version.

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Aug 28, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

cderv added 5 commits August 28, 2025 12:48
(cherry picked from commit c0d8cc3)

# Conflicts:
#	.github/workflows/create-release.yml
@cderv
Copy link
Collaborator Author

cderv commented Aug 28, 2025

So this is tested with https://github.com/quarto-dev/quarto-cli/actions/runs/17296021231

It shows that this is building now. Basically, the update to [email protected] fails.
It happens because of new release of fs-extra used by our old version of vite-plugin-static-copy (we use 0.13.1 - we should update)

It does not happen with prerelease version probably because npm is used now e5ca74f

Still this quarto-preview.js needs to be improved.

I noticed we build it twice

  • One at configure time
  • Another at prepareDist time

@cderv cderv added the backport label Aug 28, 2025
@cderv cderv merged commit e57c8ea into v1.7 Aug 28, 2025
21 of 101 checks passed
@cderv cderv deleted the fix-previewjs-build branch August 28, 2025 13:07
@cderv
Copy link
Collaborator Author

cderv commented Sep 5, 2025

For reference, this is indeed a problem with fs-extra 11.3.1 but only with Deno due to limitation with compatibility with Node. See explanation at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants