Skip to content

possible bug in fs-extra v11.3.1 #13288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 28, 2025
Merged

possible bug in fs-extra v11.3.1 #13288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e13fa0f
possible bug in fs-extra v11.3.1
cderv Aug 28, 2025
0772805
Correct path to check for quarto-preview.js
cderv Aug 28, 2025
adcb7f8
gha - can't use env var in workflow fields
cderv Aug 28, 2025
eddf9e3
gha - fix command on Windows
cderv Aug 28, 2025
e4c6e19
previewjs - Use the overrides to pin latest 11.3.0 working version of…
cderv Aug 28, 2025
be0af28
Revert "previewjs - Use the overrides to pin latest 11.3.0 working ve…
cderv Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,10 @@ jobs:
shell: bash
run: |
if [ ! -f "share/preview/quarto-preview.js" ]; then
echo "::error file=share/preview/quarto-preview.js::Required file share/preview/quarto-preview.js not found. Check the windows build configure step."
echo "::error file=share/preview/quarto-preview.js::Required file share/preview/quarto-preview.js not found. Check the linux build Prepare Distribution step."
exit 1
fi
working-directory: ${{ github.workspace }}/quarto-${{needs.configure.outputs.version}}

- run: |
tar -tzvf quarto-${{needs.configure.outputs.version}}-linux-amd64.tar.gz | head
Expand Down Expand Up @@ -388,31 +389,36 @@ jobs:
runs-on: windows-latest
needs: [configure, make-installer-win]
steps:
- uses: actions/download-artifact@v4
- name: "Download Windows Zip"
uses: actions/download-artifact@v4
with:
name: Windows Zip
path: .
- run: |

- name: "Extract Windows Zip"
run: |
tar -xf quarto-${{needs.configure.outputs.version}}-win.zip

# Check for share/preview/quarto-preview.js
- name: Ensure share/preview/quarto-preview.js exists
shell: bash
run: |
if [ ! -f "share/preview/quarto-preview.js" ]; then
echo "::error file=share/preview/quarto-preview.js::Required file share/preview/quarto-preview.js not found. Check the windows build configure step."
echo "::error file=share/preview/quarto-preview.js::Required file share/preview/quarto-preview.js not found. Check the windows build Prepare Distribution step."
exit 1
fi

- run: Add-Content $env:GITHUB_PATH "$env:GITHUB_WORKSPACE\bin"
- name: "Add bin to PATH"
run: Add-Content $env:GITHUB_PATH "$env:GITHUB_WORKSPACE\bin"

- run: |
tar -tzvf quarto-${{needs.configure.outputs.version}}-win.zip
- name: "Show Directory Listing and PATH"
run: |
ls -lR
echo $PATH
shell: bash

- run: |
- name: "Run Quarto Commands"
run: |
quarto check
quarto --paths
quarto --version
Expand Down
3 changes: 2 additions & 1 deletion src/webui/quarto-preview/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"typescript": "^4.5.2",
"vite": "^3.0.0",
"vite-plugin-css-injected-by-js": "^3.1.0",
"vite-plugin-static-copy": "^0.13.0"
"vite-plugin-static-copy": "^0.13.0",
"fs-extra": "<=11.3.0"
}
}
Loading