Skip to content

Add header html tag to CSS for monobackgroundcolor #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 161 commits into from
Closed

Add header html tag to CSS for monobackgroundcolor #6782

wants to merge 161 commits into from

Conversation

mcanouil
Copy link
Collaborator

@mcanouil mcanouil commented Sep 9, 2023

This PR adds h1-6 tags to the CSS rules to apply monobackgroundcolor on.

Fixes #6781

cderv and others added 8 commits September 8, 2023 17:25
@cderv
chores: Use a formatter for our R code based on REditorSupport extens…
fc519ed 
…ions
@cderv
[knitr] Correctly create tools:quarto env to store ojs_define for k…
b5664ee 
…nitr to find during knitting

This avoids duplication of environment, as discussed in quarto-dev#5012 (review)
@cderv
[knitr] Reformat with vscode the script
6ab343e
@cderv
[knitr] handles OJS conditional with other dependency resolution
57b7b88 
This simplifies ojs_define logic removing need for a custom function in a tools env
@cderv
[knitr] Rewrite dependencies handling by format and include ojs with …
93d1870 
…HTML
@cderv
Add test to avoid duplicated tools:quarto env
255bcd1
@mcanouil
fix: monobackgroundcolor ignored by document title and section title
94d6113 
Fixes quarto-dev#6781
@mcanouil
fix: add header to inline code style without padding
8dbf808
@mcanouil mcanouil requested a review from dragonstyle September 9, 2023 15:37
@mcanouil mcanouil self-assigned this Sep 9, 2023
@mcanouil mcanouil added enhancement New feature or request html Issues with HTML and related web technology (html/css/scss/js) themes Related to HTML theming or any other style related issue (like highlight-style) labels Sep 9, 2023
@mcanouil mcanouil mentioned this pull request Sep 9, 2023
Closed
cderv
cderv reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcanouil !

Just a note about possible simplification of our style file that we could do

cderv and others added 7 commits September 11, 2023 10:25
@cderv
Merge branch 'main' into fix/knitr/ojs-define-env
1669ef3
@cderv
Add quarto tools environment for ojs_define in changelog
afc0392
@cderv
Revert launch.json change from aad283f
028aabb 
Even if this is to modify for testing, we don't want hardcode user path otherwise we'll commit each change each time for each user.

[skip ci]
@cderv
Fix support for fig-asp as a format or execute level YAML option
3065751 
It still only works for knitr computation engine but can now correctly be used in YAML as documented in formats reference page
@cderv
[knitr improvements] OJS and dependencies resolution (quarto-dev#6775)
c738937
@cderv
Merge branch 'main' into knitr/fig-asp-global
43834cd
@mcanouil
Merge branch 'main' into fix/issue6783
5f6a831
dragonstyle and others added 25 commits September 22, 2023 10:43
@dragonstyle
Fix sketchy
aadb190
@cscheid
Render callouts to GFM (quarto-dev#6942)
f9bb1eb 
* format callout for gfm output. Closes quarto-dev#6935
* detect gfm robustly
* changelog
@Aranaur
add ukrainian translation
710e808 
* add _lanhuage-ua.yml with ukrainian translation
@Aranaur
add _language-ua.yml to README.md
66a0e65
@cscheid
fix beamer regression (quarto-dev#6952)
64f13fd
@cscheid
typst: turn .block fenced divs into #block calls
0798940
@cscheid
minimal test
3069f17
@cscheid
Merge pull request quarto-dev#6953 from Aranaur/proposed-fixes
e006009 
Language .yml file for Ukrainian
@cscheid
Merge pull request quarto-dev#6954 from quarto-dev/feature/typst-blocks
5f753f6 
Feature: typst blocks
@cderv
Handle callout title as empty table
4ad6709 
Same fix for epub and reveal than 6721856
@cderv
Callout title are no more nil
16e9fe8 
Same fix as 239a3a9
@cderv
Also check title correctly for callout attribute
23462e7
@cderv
Add some more case for html tests of callout
49161fe
@cderv
Add tests for revealjs callout formatting
be8113a
@cderv
Move boostrap update item in NEWS to HTML format part
9815b57
@cderv
Add to changelog revealjs callout fix
ac01707 
[skip ci]
@mcanouil
fix: merge css rules into one
f36fb64
@mcanouil
fix: add mono foreground option
c777e70
@mcanouil
fix: monobackgroundcolor ignored by document title and section title
a6af3e5 
Fixes quarto-dev#6781
@mcanouil
fix: add header to inline code style without padding
577d05b
@mcanouil
fix: monobackgroundcolor ignored by document title and section title
a8f13a7 
Fixes quarto-dev#6781
@mcanouil
fix: merge css rules into one
d6c7149
@mcanouil
fix: add mono foreground option
e9ee2ee
@mcanouil
chore: merger from main
5ced7ac
@mcanouil
build: quarto build-js
a1c99d2
@mcanouil mcanouil marked this pull request as draft September 24, 2023 10:41
@mcanouil mcanouil mentioned this pull request Sep 24, 2023
Merged
@mcanouil
Copy link
Collaborator Author

Closing in favour of:

@mcanouil mcanouil closed this Sep 24, 2023
@mcanouil mcanouil deleted the fix/issue6781 branch September 24, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cderv cderv cderv left review comments

@dragonstyle dragonstyle Awaiting requested review from dragonstyle

Assignees

@mcanouil mcanouil

Labels

enhancement New feature or request html Issues with HTML and related web technology (html/css/scss/js) themes Related to HTML theming or any other style related issue (like highlight-style)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

monobackgroundcolor ignored by document title and section title

7 participants

@mcanouil @cderv @dragonstyle @jjallaire @cscheid @knuesel @Aranaur