Skip to content

Conversation

mcanouil
Copy link
Collaborator

@mcanouil mcanouil commented Sep 24, 2023

This PR:

This PR accounts for the comment made on #6782 and do not run quarto build-js to avoid merge conflicts.
It also integrates #6785 to ease review as the two are heavily related.
Also this PR ensure it is up to date with main which had a lot of commits recently.

Note that quarto build-js was not executed to avoid conflicts, thus it will be required on merge.


---
title: "Document title with `code`"
format:
  html:
    monobackgroundcolor: "transparent"
    monoforegroundcolor: "#b22222"
---

# Section title with `code`

Some text with `code`

@mcanouil mcanouil added themes Related to HTML theming or any other style related issue (like highlight-style) enhancement New feature or request html Issues with HTML and related web technology (html/css/scss/js) labels Sep 24, 2023
@mcanouil mcanouil marked this pull request as ready for review September 24, 2023 11:10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This files is directly from Pandoc templates (https://github.com/jgm/pandoc/blob/49e64c1451b9933a025d059f7dae287788c7d1cc/data/templates/styles.html), and monobackgroundcolor is one of Pandoc's variable for HTML (https://pandoc.org/MANUAL.html#variables-for-html)

monoforegroundcolor is not. So it will require to patch the file at each update.

Also this part of the style file is used only when document-css variables is activated. I believe this is only with theme: pandoc in Quarto.

Do we really want to add this monoforegroundcolor support for non bootstrap document ?

If we think this is desired, I think we should do a PR or feature request in Pandoc to add it there for future version (so that no patch is needed on our side)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this was why at first it was two PRs to get reviews.
This PRs mostly serves as a discussion point for this.

@mcanouil mcanouil removed the request for review from dragonstyle March 16, 2024 22:22
@cderv cderv added the needs-discussion Issues that require a team-wide discussion before proceeding further label Apr 29, 2024
@cscheid cscheid added this to the v1.6 milestone Jun 27, 2024
@cscheid cscheid modified the milestones: v1.6, v1.7 Nov 22, 2024
@cscheid cscheid modified the milestones: v1.7, v1.8 Apr 2, 2025
@cscheid
Copy link
Collaborator

cscheid commented Apr 8, 2025

Thank you!

@cscheid cscheid merged commit ca817b6 into quarto-dev:main Apr 8, 2025
49 checks passed
@cscheid
Copy link
Collaborator

cscheid commented Apr 8, 2025

Ooof, I'm sorry. I made a mess here. I was looking to merge your schema PR and must have accidentally clicked the wrong button.

@mcanouil
Copy link
Collaborator Author

mcanouil commented Apr 8, 2025

Is it worth to make a new PR? It's very old (September 2023) and, you know, time is limited^^
I've reopened the issue:

@cscheid
Copy link
Collaborator

cscheid commented Apr 8, 2025

I think we need to address Christophe's concerns before merging a PR to solve the issue. So we don't need to reopen this one right away, and we have your proposal as a point of discussion like you mention. Thanks, and sorry for the confusion again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request html Issues with HTML and related web technology (html/css/scss/js) needs-discussion Issues that require a team-wide discussion before proceeding further themes Related to HTML theming or any other style related issue (like highlight-style)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

monobackgroundcolor ignored by document title and section title

3 participants