-
Notifications
You must be signed in to change notification settings - Fork 383
fix: header html tag for monobackgroundcolor
+ monoforegroundcolor
option
#6969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This files is directly from Pandoc templates (https://github.com/jgm/pandoc/blob/49e64c1451b9933a025d059f7dae287788c7d1cc/data/templates/styles.html), and monobackgroundcolor
is one of Pandoc's variable for HTML (https://pandoc.org/MANUAL.html#variables-for-html)
monoforegroundcolor
is not. So it will require to patch the file at each update.
Also this part of the style file is used only when document-css
variables is activated. I believe this is only with theme: pandoc
in Quarto.
Do we really want to add this monoforegroundcolor
support for non bootstrap document ?
If we think this is desired, I think we should do a PR or feature request in Pandoc to add it there for future version (so that no patch is needed on our side)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this was why at first it was two PRs to get reviews.
This PRs mostly serves as a discussion point for this.
Thank you! |
Ooof, I'm sorry. I made a mess here. I was looking to merge your schema PR and must have accidentally clicked the wrong button. |
Is it worth to make a new PR? It's very old (September 2023) and, you know, time is limited^^ |
I think we need to address Christophe's concerns before merging a PR to solve the issue. So we don't need to reopen this one right away, and we have your proposal as a point of discussion like you mention. Thanks, and sorry for the confusion again. |
This PR:
monobackgroundcolor
on.Fixes
monobackgroundcolor
ignored by document title and section title #6781monoforegroundcolor
option.Fixes Add option for changing inline code color #6780
This PR accounts for the comment made on #6782 and do not run
quarto build-js
to avoid merge conflicts.It also integrates #6785 to ease review as the two are heavily related.
Also this PR ensure it is up to date with
main
which had a lot of commits recently.Note that
quarto build-js
was not executed to avoid conflicts, thus it will be required on merge.