Skip to content

Force a user save on untitled documents, before switch to visual mode #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2025
Merged

Force a user save on untitled documents, before switch to visual mode #831

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c151c80
Force a user save on untitled documents, before switch to visual mode
juliasilge Sep 29, 2025
e92e07d
Update CHANGELOG
juliasilge Sep 29, 2025
6a93a72
Merge branch 'main' into force-save-before-switch
juliasilge Oct 1, 2025
6b416d3
Fix for opening unsaved file in VE in VSCode
vezwork Oct 1, 2025
0117331
Make linter happy
juliasilge Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
## 1.125.0 (Unreleased)

- Fixed an issue where attribute values containing '='s could be truncated in some scenarios (<https://github.com/quarto-dev/quarto/pull/814>).
- Fixed an issue where a loading spinner for qmd previews wasn't dismissed on preview errors (<https://github.com/quarto-dev/quarto/pull/823>)
- Fixed an issue where a loading spinner for qmd previews wasn't dismissed on preview errors (<https://github.com/quarto-dev/quarto/pull/823>).
- Diagnostics are no longer reported for internal temporary virtual document files (<https://github.com/quarto-dev/quarto/pull/832>).
- Fixed switching to visual mode for untitled documents in Positron (<https://github.com/quarto-dev/quarto/pull/831>).

## 1.124.0 (Release on 2025-08-20)

Expand Down
5 changes: 5 additions & 0 deletions apps/vscode/src/providers/editor/toggle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ export async function reopenEditorInVisualMode(
if (hasHooks()) {
// note pending switch to visual
VisualEditorProvider.recordPendingSwitchToVisual(document);
// if document is untitled, force user to save first
if (document.isUntitled) {
await commands.executeCommand("workbench.action.files.save");
}
// reopen in visual mode
commands.executeCommand('positron.reopenWith', document.uri, 'quarto.visualEditor');
} else {
// save then close
Expand Down