Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/lsp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"node-html-parser": "^6.1.5",
"picomatch": "^2.3.1",
"quarto-core": "*",
"vscode-quarto-utils": "*",
"uuid": "^8.3.2",
"vscode-languageserver": "^8.1.0",
"vscode-languageserver-textdocument": "^1.0.4",
Expand Down
2 changes: 1 addition & 1 deletion apps/lsp/src/r-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
*/

import { isRPackage as isRPackageImpl } from "@utils/r-utils";
import { isRPackage as isRPackageImpl } from "vscode-quarto-utils";
Copy link
Collaborator

@lionel- lionel- Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem right for the LSP to depend on a "vscode" module. How about quarto-lsp-utils?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used elsewhere in the VS Code extension not in functionality that has anything to do with an LSP, so that doesn't seem right either.

Maybe just quarto-utils?

Copy link
Collaborator Author

@juliasilge juliasilge Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or quarto-workspace-utils or extension-utils or shared-utils?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quarto-utils seems good!

import { IWorkspace } from './service';

// Version that selects workspace folder
Expand Down
5 changes: 1 addition & 4 deletions apps/lsp/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@
"module": "CommonJS",
"outDir": "./dist",
"sourceMap": true,
"resolveJsonModule": true,
"paths": {
"@utils/*": ["../utils/*"]
}
"resolveJsonModule": true
},
"exclude": ["node_modules"],
"extends": "tsconfig/base.json",
Expand Down
16 changes: 16 additions & 0 deletions apps/vscode-quarto-utils/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"name": "vscode-quarto-utils",
"version": "0.0.0",
"private": true,
"license": "agpl-3.0",
"main": "./src/index.ts",
"types": "./src/index.ts",
"dependencies": {
"tsconfig": "*",
"typescript": "^4.5.2",
"vscode-uri": "^3.0.3"
},
"devDependencies": {
"@types/node": "^20.10.6"
}
}
16 changes: 16 additions & 0 deletions apps/vscode-quarto-utils/src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* index.ts
*
* Copyright (C) 2025 by Posit Software, PBC
*
* Unless you have received this program directly from Posit Software pursuant
* to the terms of a commercial license agreement with Posit Software, then
* this program is licensed to you under the terms of version 3 of the
* GNU Affero General Public License. This program is distributed WITHOUT
* ANY EXPRESS OR IMPLIED WARRANTY, INCLUDING THOSE OF NON-INFRINGEMENT,
* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. Please refer to the
* AGPL (http://www.gnu.org/licenses/agpl-3.0.txt) for more details.
*
*/

export * from './r-utils';
File renamed without changes.
1 change: 1 addition & 0 deletions apps/vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1467,6 +1467,7 @@
"@posit-dev/positron": "^0.1.0",
"quarto-core": "*",
"quarto-lsp": "*",
"vscode-quarto-utils": "*",
"quarto-vscode-editor": "*",
"quarto-vscode-markdownit": "*",
"semver": "^7.3.8",
Expand Down
2 changes: 1 addition & 1 deletion apps/vscode/src/r-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*/

import * as vscode from 'vscode';
import { isRPackage as isRPackageImpl } from "@utils/r-utils";
import { isRPackage as isRPackageImpl } from "vscode-quarto-utils";

// Version that selects workspace folder
export async function isRPackage(): Promise<boolean> {
Expand Down
5 changes: 1 addition & 4 deletions apps/vscode/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
"outDir": "out",
"lib": ["ES2021"],
"sourceMap": true,
"strict": true,
"paths": {
"@utils/*": ["../utils/*"]
}
"strict": true
/* enable all strict type-checking options */
/* Additional Checks */
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
Expand Down