Skip to content

Add fix to peer discovery logic. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LINCKODE wants to merge 2 commits into from
Closed

Add fix to peer discovery logic. #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4db1f46
Add fix to peer discovery logic.
LINCKODE Mar 3, 2026
51f3d94
Deploy fix as custom version for testing.
LINCKODE Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/push-docker-custom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Deploy dev images to GHCR
on:
push:
branches:
- 'feature/public-peers'
- 'peer-discovery-issue'

jobs:
push-store-image:
Expand All @@ -21,5 +21,5 @@ jobs:

- name: 'Build Inventory Image'
run: |
docker build . --tag ghcr.io/qubic/qubic-nodes:public-peers
docker push ghcr.io/qubic/qubic-nodes:public-peers
docker build . --tag ghcr.io/qubic/qubic-nodes:peer-discovery-issue
docker push ghcr.io/qubic/qubic-nodes:peer-discovery-issue
6 changes: 4 additions & 2 deletions node/peer_discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,10 @@ func (ppd *PublicPeerDiscovery) FindNewPeers(nodes []*Node, addresses []string)
for _, node := range nodes {
ppd.lookupPeers(node.Peers, peers, nodesChannel, &waitGroup)
}
waitGroup.Wait()
close(nodesChannel)
go func() {
Copy link
Member

@qubicmio qubicmio Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this most certainly makes the code continue I don't think it fixes the underlying issue.

waitGroup.Wait()
close(nodesChannel)
}()

var newNodes []*Node
for node := range nodesChannel {
Expand Down
Loading