Closed
Conversation
qubicmio
reviewed
Mar 4, 2026
| } | ||
| waitGroup.Wait() | ||
| close(nodesChannel) | ||
| go func() { |
Member
There was a problem hiding this comment.
While this most certainly makes the code continue I don't think it fixes the underlying issue.
Member
|
As agreed on. This is not a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FindNewPeers method had a deadlock: the channel was only read after waitGroup.Wait(), but goroutines blocked on sending to the full channel prevented Wait from ever returning. When the recursive peer discovery found more than 50 nodes, the 51st send blocked, leaked the goroutine, and silently prevented any discovered peers from being added. The fix moves waitGroup.Wait() and close() into a separate goroutine so the channel is drained concurrently with discovery, preventing the buffer from filling up.