Skip to content

refactor(quinn): Remove some usage of execute_poll #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

refactor(quinn): Remove some usage of execute_poll #2232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions quinn/src/send_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use std::{
future::{Future, poll_fn},
io,
pin::Pin,
pin::{Pin, pin},
task::{Context, Poll},
};

Expand Down Expand Up @@ -241,14 +241,14 @@ impl SendStream {
cx: &mut Context,
buf: &[u8],
) -> Poll<Result<usize, WriteError>> {
self.get_mut().execute_poll(cx, |stream| stream.write(buf))
pin!(self.get_mut().write(buf)).as_mut().poll(cx)
}
}

#[cfg(feature = "futures-io")]
impl futures_io::AsyncWrite for SendStream {
fn poll_write(self: Pin<&mut Self>, cx: &mut Context, buf: &[u8]) -> Poll<io::Result<usize>> {
Self::execute_poll(self.get_mut(), cx, |stream| stream.write(buf)).map_err(Into::into)
self.poll_write(cx, buf).map_err(Into::into)
}

fn poll_flush(self: Pin<&mut Self>, _cx: &mut Context) -> Poll<io::Result<()>> {
Expand All @@ -266,7 +266,7 @@ impl tokio::io::AsyncWrite for SendStream {
cx: &mut Context<'_>,
buf: &[u8],
) -> Poll<io::Result<usize>> {
Self::execute_poll(self.get_mut(), cx, |stream| stream.write(buf)).map_err(Into::into)
self.poll_write(cx, buf).map_err(Into::into)
}

fn poll_flush(self: Pin<&mut Self>, _cx: &mut Context) -> Poll<io::Result<()>> {
Expand Down