Remove any trace of real estate module

[aaccensi]

Description

As requested in quintel/etsource#3098, this PR is part of a set of 3 PRs with the goal of removing any trace of real estate module:

• Atlas: Remove any trace of real estate module atlas#183
• ETEngine: Remove any trace of real estate module #1690 [First Atlas merge*] (this one)
• ETSource: Remove real estate module from datasets etsource#3402 [First Atlas merge*]

* Note that since Atlas is a Gem, we should follow this order:

1. Merge the Atlas PR, get new commit SHA
2. Update etengine/Gemfile and etsource/Gemfile with new Atlas ref, then retest and merge those PRs together (since they contain the removal of code that depends on the deleted Atlas functionality).

Type of change

• Bug fix
• New feature
• Enhancement
• Documentation
• Maintenance

Checklist

• I have tested these changes
• I have updated documentation as needed
• I have tagged the relevant people for review

Related Issues

References quintel/etsource#3098

[mabijkerk]

If we update Atlas, we also have to update relevant Gemfiles.

[aaccensi]

If we update Atlas, we also have to update relevant Gemfiles.

Oh, you are right. this has some implications, we should follow this order:

1. Merge the Atlas PR, get new commit SHA
2. Update etengine/Gemfile and etsource/Gemfile with new Atlas ref, then retest and merge those PRs together (since they contain the removal of code that depends on the deleted Atlas functionality).

[mabijkerk]

Yes, though we typically already test the Atlas commit of the branch before we even merge it.

[aaccensi]

Yes, though we typically already test the Atlas commit of the branch before we even merge it.

That is good to know. To get ahead of potential issues I did that locally for both ETSource and ETEngine.
I pointed the atlas gem to the new branch and I updated it. The specs for both repos still pass and seem to work fine.

[louispt1]

LGTM!