Remove real estate module from datasets #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaccensi
reviewed
Jan 7, 2026
Contributor
aaccensi
left a comment
aaccensi
left a comment
There was a problem hiding this comment.
My research about removing any trace of this pointed that in etsource there is also a gql that I believe we can delete.
If I'm not mistaken it is not being used anywhere (otherwise it could need rewriting):
gqueries/modules/holon/economy/depreciation_costs_assets/depreciation_costs_existing_terraced_houses_per_house_per_percentage.gql
…e module References #3098
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Heat improvements project, the real estate cost module was replace by a simple set of queries. The real estate module then became redundant, but had never been removed. This PR removes the remaining data for the real estate module.
See #3098
This PR is part of a set of 3 PRs:
* Note that since Atlas is a Gem, we should follow this order:
etengine/Gemfileandetsource/Gemfilewith new Atlasref, then retest and merge those PRs together (since they contain the removal of code that depends on the deleted Atlas functionality).